Skip to content

Commit 7b457dc

Browse files
committed
sea-operation: refresh test fakes for the merged-kernel binding surface
Rebased onto the updated sea-results. Makes the StatementStub (SeaIntervalParity) and the local NativeStatement interface (lifecycle e2e) use a synchronous schema() to match the merged-kernel binding, so the specs type-check against SeaOperationStatement. Co-authored-by: Isaac
1 parent 1f77d96 commit 7b457dc

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

tests/e2e/sea/operation-lifecycle-e2e.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,8 @@ interface NativeConnection {
6969

7070
interface NativeStatement {
7171
fetchNextBatch(): Promise<{ ipcBytes: Buffer } | null>;
72-
schema(): Promise<{ ipcBytes: Buffer }>;
72+
// schema() is synchronous on the merged-kernel binding.
73+
schema(): { ipcBytes: Buffer };
7374
cancel(): Promise<void>;
7475
close(): Promise<void>;
7576
}

tests/unit/sea/SeaIntervalParity.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,8 @@ class StatementStub {
8585
return { ipcBytes: this.batches.shift() as Buffer };
8686
}
8787

88-
public async schema(): Promise<{ ipcBytes: Buffer }> {
88+
// schema() is synchronous on the merged-kernel binding.
89+
public schema(): { ipcBytes: Buffer } {
8990
return { ipcBytes: this.schemaIpc };
9091
}
9192

0 commit comments

Comments
 (0)