Commit 87bc9ce
committed
fix(sea): make @napi-rs/cli optional + prettier-format loader test
Two CI failures, both unrelated to driver behavior:
1. unit-test/lint/e2e intermittently failed at `npm ci` with ECONNRESET
fetching @napi-rs/cli@2.18.4 from the internal npm proxy (cold-cache
matrix jobs; the warm-cache node-14 job kept passing). @napi-rs/cli is
only used by `build:native`, which CI never runs. Move it from
devDependencies to optionalDependencies — matching the existing lz4
pattern — so a proxy hiccup is a non-fatal skip instead of failing the
whole install. `build:native`'s `npx --no-install` still resolves it on
dev machines where the optional install succeeds.
2. prettier flagged loader.test.ts: the two-arg `new SeaNativeLoader(cb, fn)`
calls needed multi-line formatting. Ran prettier --write.
Co-authored-by: Isaac
Signed-off-by: Madhavendra Rathore <madhavendra.rathore@databricks.com>1 parent cee1e14 commit 87bc9ce
3 files changed
Lines changed: 16 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
53 | 52 | | |
54 | 53 | | |
55 | 54 | | |
| |||
92 | 91 | | |
93 | 92 | | |
94 | 93 | | |
95 | | - | |
| 94 | + | |
| 95 | + | |
96 | 96 | | |
97 | 97 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
126 | 126 | | |
127 | 127 | | |
128 | 128 | | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
133 | 136 | | |
134 | 137 | | |
135 | 138 | | |
136 | 139 | | |
137 | 140 | | |
138 | | - | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
139 | 145 | | |
140 | 146 | | |
141 | 147 | | |
| |||
0 commit comments