renamed other as client_cert in auth_mech

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

Author: saishreeeee

src/databricks/sql/telemetry/models/enums.py

@@ -7,10 +7,10 @@ class AuthFlow(Enum):
 
 
 class AuthMech(Enum):
-    OTHER = "OTHER"
-    PAT = "PAT"
-    DATABRICKS_OAUTH = "DATABRICKS_OAUTH"
-    EXTERNAL_AUTH = "EXTERNAL_AUTH"
+    CLIENT_CERT = "CLIENT_CERT"  # ssl certificate authentication
+    PAT = "PAT"  # Personal Access Token authentication
+    DATABRICKS_OAUTH = "DATABRICKS_OAUTH"  # Databricks-managed OAuth flow
+    EXTERNAL_AUTH = "EXTERNAL_AUTH"  # External identity provider (AWS, Azure, etc.)
 
 
 class DatabricksClientType(Enum):

src/databricks/sql/telemetry/telemetry_client.py

@@ -55,6 +55,9 @@ def getDriverSystemConfiguration(cls) -> DriverSystemConfiguration:
     @staticmethod
     def get_auth_mechanism(auth_provider):
         """Get the auth mechanism for the auth provider."""
+        # AuthMech is an enum with the following values:
+        # PAT, DATABRICKS_OAUTH, EXTERNAL_AUTH, CLIENT_CERT
+
         if not auth_provider:
             return None
         if isinstance(auth_provider, AccessTokenAuthProvider):
@@ -65,11 +68,14 @@ def get_auth_mechanism(auth_provider):
             return (
                 AuthMech.EXTERNAL_AUTH
             )  # External identity provider (AWS, Azure, etc.)
-        return AuthMech.OTHER  # Custom or unknown authentication provider
+        return AuthMech.CLIENT_CERT  # Client certificate (ssl)
 
     @staticmethod
     def get_auth_flow(auth_provider):
         """Get the auth flow for the auth provider."""
+        # AuthFlow is an enum with the following values:
+        # TOKEN_PASSTHROUGH, BROWSER_BASED_AUTHENTICATION
+
         if not auth_provider:
             return None
 
@@ -78,7 +84,6 @@ def get_auth_flow(auth_provider):
                 return (
                     AuthFlow.TOKEN_PASSTHROUGH
                 )  # Has existing tokens, no user interaction needed
-
             if hasattr(auth_provider, "oauth_manager"):
                 return (
                     AuthFlow.BROWSER_BASED_AUTHENTICATION