Skip to content

Commit da5ad94

Browse files
committed
Simplify None handling in query_tags serialization
Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
1 parent 568b0de commit da5ad94

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

src/databricks/sql/backend/sea/models/requests.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,10 @@ def to_dict(self) -> Dict[str, Any]:
6262
]
6363

6464
# SEA API expects query_tags as an array of {key, value} objects.
65-
# None values are represented by omitting the "value" field.
65+
# None/empty values are left to the server to handle as key-only tags.
6666
if self.query_tags:
6767
result["query_tags"] = [
68-
{"key": k, "value": v} if v is not None else {"key": k}
69-
for k, v in self.query_tags.items()
68+
{"key": k, "value": v} for k, v in self.query_tags.items()
7069
]
7170

7271
return result

tests/unit/test_sea_backend.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -473,7 +473,7 @@ def test_execute_command_query_tags_none_value(
473473
_, kwargs = mock_http_client._make_request.call_args
474474
assert kwargs["data"]["query_tags"] == [
475475
{"key": "env", "value": "prod"},
476-
{"key": "team"},
476+
{"key": "team", "value": None},
477477
]
478478

479479
def test_execute_command_no_query_tags_omitted(

0 commit comments

Comments
 (0)