Skip to content

Commit 010803e

Browse files
committed
Drop the DEBUG log — redundant with sqlalchemy.engine's own logging
The prior commit added a DEBUG log in __init__ recording the compiled statement. SQLAlchemy's own sqlalchemy.engine logger already exposes the compiled SQL (via echo=True or the standard engine logger), so our log duplicates that surface for no added signal. Dropping it keeps the dialect consistent with the existing "warnings only" logging style — no other DEBUG-level log exists in the codebase. Co-authored-by: Isaac Signed-off-by: Madhavendra Rathore <madhavendra.rathore@databricks.com>
1 parent 05c180f commit 010803e

1 file changed

Lines changed: 0 additions & 12 deletions

File tree

src/databricks/sqlalchemy/_ddl.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -120,18 +120,6 @@ class DatabricksStatementCompiler(compiler.SQLCompiler):
120120
bindtemplate = property(lambda self: self._BIND_TEMPLATE, lambda self, _: None)
121121
compilation_bindtemplate = property(lambda self: self._BIND_TEMPLATE, lambda self, _: None)
122122

123-
def __init__(self, *args, **kwargs):
124-
super().__init__(*args, **kwargs)
125-
# One-line trace of what we rendered — helps debug reported SQL
126-
# issues without adding per-bindparam noise.
127-
if logger.isEnabledFor(logging.DEBUG):
128-
logger.debug(
129-
"DatabricksStatementCompiler compiled statement with "
130-
"backtick-quoted bind markers (template=%s): %s",
131-
self._BIND_TEMPLATE,
132-
self.string,
133-
)
134-
135123
def limit_clause(self, select, **kw):
136124
"""Identical to the default implementation of SQLCompiler.limit_clause except it writes LIMIT ALL instead of LIMIT -1,
137125
since Databricks SQL doesn't support the latter.

0 commit comments

Comments
 (0)