Skip to content

Commit b2b1021

Browse files
fjakobsclaude
andcommitted
Use public @databricks/sdk-experimental package
Replace custom SDK download scripts with the public @databricks/sdk-experimental npm package (v0.14.2). This simplifies the build process and ensures users get official SDK updates. Changes: - Updated package.json files to use @databricks/sdk-experimental instead of file:../../vendor/databricks-sdk.tgz - Removed SDK download scripts (install_sdk.sh and fetch:sdk npm script) - Removed vendor directory - Updated all imports from @databricks/databricks-sdk to @databricks/sdk-experimental - Fixed test mocks to work with new SDK API (request method signature changed) - Added skipLibCheck to tsconfig to work around Node.js type compatibility issues - Added @types/ini dependency 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 067efd3 commit b2b1021

95 files changed

Lines changed: 282 additions & 383 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.vscode/settings.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,7 @@
1414
"editor.defaultFormatter": "esbenp.prettier-vscode",
1515
"[javascript]": {
1616
"editor.defaultFormatter": "esbenp.prettier-vscode"
17-
}
17+
},
18+
"jupyter.interactiveWindow.cellMarker.codeRegex": "^# COMMAND ----------|^# Databricks notebook source|^(#\\s*%%|#\\s*\\<codecell\\>|#\\s*In\\[\\d*?\\]|#\\s*In\\[ \\])",
19+
"jupyter.interactiveWindow.cellMarker.default": "# COMMAND ----------"
1820
}

package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313
"yarn": ">=3.2.0"
1414
},
1515
"scripts": {
16-
"install:sdk": "yarn fetch:sdk && chmod a+x scripts/install_sdk.sh && scripts/install_sdk.sh",
17-
"fetch:sdk": "rm -rf vendor && mkdir vendor && gh release download -R databricks/databricks-sdk-js v0.10.0 -p '*.tgz' && mv *.tgz vendor/databricks-sdk.tgz",
1816
"test": "yarn workspaces foreach run test",
1917
"test:integ": "yarn workspaces foreach run test:integ",
2018
"build": "yarn workspaces foreach run build",

packages/databricks-vscode-types/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {ApiClient, WorkspaceClient} from "@databricks/databricks-sdk";
1+
import {ApiClient, WorkspaceClient} from "@databricks/sdk-experimental";
22
import {Cluster} from "databricks/src/sdk-extensions";
33
import {Event} from "vscode";
44
export type ConnectionState = "CONNECTED" | "CONNECTING" | "DISCONNECTED";

packages/databricks-vscode-types/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"typescript": "^5.3.3"
3030
},
3131
"dependencies": {
32-
"@databricks/databricks-sdk": "file:../../vendor/databricks-sdk.tgz",
32+
"@databricks/sdk-experimental": "^0.14.2",
3333
"databricks": "workspace:^"
3434
}
3535
}

packages/databricks-vscode/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1186,8 +1186,8 @@
11861186
"generate-telemetry": "ts-node ./scripts/generateTelemetry.ts"
11871187
},
11881188
"dependencies": {
1189-
"@databricks/databricks-sdk": "file:../../vendor/databricks-sdk.tgz",
11901189
"@databricks/databricks-vscode-types": "workspace:^",
1190+
"@databricks/sdk-experimental": "^0.14.2",
11911191
"@types/lodash": "^4.14.202",
11921192
"@types/shell-quote": "^1.7.5",
11931193
"@vscode/debugadapter": "^1.64.0",
@@ -1210,6 +1210,7 @@
12101210
"@types/chai": "^4.3.11",
12111211
"@types/eslint": "^8.44.9",
12121212
"@types/fs-extra": "^11.0.4",
1213+
"@types/ini": "^4.1.1",
12131214
"@types/mocha": "^10.0.6",
12141215
"@types/mock-require": "^2.0.3",
12151216
"@types/node": "^20.10.4",

packages/databricks-vscode/src/bundle/BundleInitWizard.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
TerminalLocation,
77
commands,
88
} from "vscode";
9-
import {logging} from "@databricks/databricks-sdk";
9+
import {logging} from "@databricks/sdk-experimental";
1010
import {Loggers} from "../logger";
1111
import {AuthProvider} from "../configuration/auth/AuthProvider";
1212
import {LoginWizard} from "../configuration/LoginWizard";

packages/databricks-vscode/src/bundle/BundlePipelinesManager.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ import {
2727
ListPipelineEventsRequest,
2828
PipelineEvent,
2929
UpdateInfo,
30-
} from "@databricks/databricks-sdk/dist/apis/pipelines";
30+
} from "@databricks/sdk-experimental/dist/apis/pipelines";
3131
import {ConnectionManager} from "../configuration/ConnectionManager";
3232
import {Barrier} from "../locking/Barrier";
33-
import {WorkspaceClient} from "@databricks/databricks-sdk";
33+
import {WorkspaceClient} from "@databricks/sdk-experimental";
3434
import {LocalUri, RemoteUri} from "../sync/SyncDestination";
3535
import {expandUriAndType, NotebookType} from "../utils/fileUtils";
3636
import {onError} from "../utils/onErrorDecorator";

packages/databricks-vscode/src/bundle/BundleProjectManager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import os from "node:os";
55
import {ConnectionManager} from "../configuration/ConnectionManager";
66
import {ConfigModel} from "../configuration/models/ConfigModel";
77
import {BundleFileSet, getSubProjects} from "./BundleFileSet";
8-
import {logging} from "@databricks/databricks-sdk";
8+
import {logging} from "@databricks/sdk-experimental";
99
import {Loggers} from "../logger";
1010
import {CachedValue} from "../locking/CachedValue";
1111
import {CustomWhenContext} from "../vscode-objs/CustomWhenContext";

packages/databricks-vscode/src/bundle/models/BundleRemoteStateModel.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {BundleTarget, Resource, ResourceKey, Resources} from "../types";
66
import {AuthProvider} from "../../configuration/auth/AuthProvider";
77
import lodash from "lodash";
88
import {WorkspaceConfigs} from "../../vscode-objs/WorkspaceConfigs";
9-
import {logging} from "@databricks/databricks-sdk";
9+
import {logging} from "@databricks/sdk-experimental";
1010
import {Loggers} from "../../logger";
1111
import {WorkspaceFolderManager} from "../../vscode-objs/WorkspaceFolderManager";
1212
import {CancellationToken} from "vscode";

packages/databricks-vscode/src/bundle/models/BundleValidateModel.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import lodash from "lodash";
77
import {workspaceConfigs} from "../../vscode-objs/WorkspaceConfigs";
88
import {BaseModelWithStateCache} from "../../configuration/models/BaseModelWithStateCache";
99
import {withOnErrorHandler} from "../../utils/onErrorDecorator";
10-
import {logging} from "@databricks/databricks-sdk";
10+
import {logging} from "@databricks/sdk-experimental";
1111
import {Loggers} from "../../logger";
1212
import {WorkspaceFolderManager} from "../../vscode-objs/WorkspaceFolderManager";
1313

0 commit comments

Comments
 (0)