Skip to content

Commit d521930

Browse files
authored
Fix write permissions in release workflows (#1880)
## Summary - PR #1873 added explicit `permissions` blocks with `contents: read` to all jobs for JFrog OIDC support. This inadvertently revoked the implicit `contents: write` that release operations require. - `create-release.yml`: `contents: read` → `write` (needed for `gh release create`) - `nightly-release.yml`: `contents: read` → `write` (needed for `softprops/action-gh-release`) - `release-pr.yml`: `contents: read` → `write` + added `pull-requests: write` (needed for `git push` + `gh pr create`) ## Test plan - [ ] Merge and trigger nightly release (push to main) — verify `create-build-artifacts` + `create-release` both succeed - [ ] Trigger `release-pr.yml` manually with a test version — verify branch creation + PR creation succeed - [ ] Trigger `create-release.yml` manually — verify draft GitHub Release is created with VSIX artifacts This pull request and its description were written by Isaac.
1 parent 3f54441 commit d521930

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

.github/workflows/create-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222

2323
permissions:
2424
id-token: write
25-
contents: read
25+
contents: write
2626

2727
steps:
2828
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1

.github/workflows/nightly-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919

2020
permissions:
2121
id-token: write
22-
contents: read
22+
contents: write
2323

2424
steps:
2525
- uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0

.github/workflows/release-pr.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ jobs:
2323

2424
permissions:
2525
id-token: write
26-
contents: read
26+
contents: write
27+
pull-requests: write
2728

2829
strategy:
2930
matrix:

0 commit comments

Comments
 (0)