Commit 75a59a3
committed
fix: address review feedback on identifier length validation
- Add @classmethod decorator and -> int return type to relation_max_name_length()
- Broaden error message to not mention store_failures specifically; the
validator fires on any oversized identifier (models, seeds, snapshots, etc.)
- Remove test_relation_max_name_length test (failing and not required per review)
- Move CHANGELOG entry from 1.11.7 to new 1.11.8 section
https://claude.ai/code/session_017ZAXMwLSnqz4FqvTt5H7D11 parent a8b866b commit 75a59a3
3 files changed
Lines changed: 11 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
1 | 7 | | |
2 | 8 | | |
3 | 9 | | |
| |||
10 | 16 | | |
11 | 17 | | |
12 | 18 | | |
13 | | - | |
14 | 19 | | |
15 | 20 | | |
16 | 21 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | | - | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
97 | 99 | | |
98 | 100 | | |
99 | | - | |
| 101 | + | |
| 102 | + | |
100 | 103 | | |
101 | 104 | | |
102 | 105 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
373 | 373 | | |
374 | 374 | | |
375 | 375 | | |
376 | | - | |
377 | | - | |
378 | | - | |
379 | 376 | | |
380 | 377 | | |
381 | 378 | | |
| |||
0 commit comments