Skip to content

Commit a64def2

Browse files
committed
ci: test fixes
1 parent 3754cb9 commit a64def2

4 files changed

Lines changed: 16 additions & 3 deletions

File tree

.github/workflows/integration.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -248,6 +248,8 @@ jobs:
248248
DBT_DATABRICKS_UC_INITIAL_CATALOG: peco
249249
DBT_DATABRICKS_LOCATION_ROOT: ${{ secrets.TEST_PECO_EXTERNAL_LOCATION }}test
250250
TEST_PECO_UC_CLUSTER_ID: ${{ secrets.TEST_PECO_UC_CLUSTER_ID }}
251+
TEST_PECO_SPOG_HOST: ${{ secrets.TEST_PECO_SPOG_HOST }}
252+
TEST_PECO_SPOG_WORKSPACE_ID: ${{ secrets.TEST_PECO_SPOG_WORKSPACE_ID }}
251253
UV_FROZEN: "1"
252254
steps:
253255
- name: Check out repository
@@ -349,6 +351,8 @@ jobs:
349351
DBT_DATABRICKS_UC_INITIAL_CATALOG: peco
350352
DBT_DATABRICKS_LOCATION_ROOT: ${{ secrets.TEST_PECO_EXTERNAL_LOCATION }}test
351353
TEST_PECO_UC_CLUSTER_ID: ${{ secrets.TEST_PECO_UC_CLUSTER_ID }}
354+
TEST_PECO_SPOG_HOST: ${{ secrets.TEST_PECO_SPOG_HOST }}
355+
TEST_PECO_SPOG_WORKSPACE_ID: ${{ secrets.TEST_PECO_SPOG_WORKSPACE_ID }}
352356
UV_FROZEN: "1"
353357
steps:
354358
- name: Check out repository
@@ -448,6 +452,8 @@ jobs:
448452
DBT_DATABRICKS_CLIENT_SECRET: ${{ secrets.TEST_PECO_SP_SECRET }}
449453
TEST_PECO_CLUSTER_ID: ${{ secrets.TEST_PECO_CLUSTER_ID }}
450454
DBT_DATABRICKS_LOCATION_ROOT: ${{ secrets.TEST_PECO_EXTERNAL_LOCATION }}test
455+
TEST_PECO_SPOG_HOST: ${{ secrets.TEST_PECO_SPOG_HOST }}
456+
TEST_PECO_SPOG_WORKSPACE_ID: ${{ secrets.TEST_PECO_SPOG_WORKSPACE_ID }}
451457
UV_FROZEN: "1"
452458
steps:
453459
- name: Check out repository

.github/workflows/spog-integration.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ jobs:
9898
DBT_DATABRICKS_LOCATION_ROOT: ${{ secrets.TEST_PECO_EXTERNAL_LOCATION }}test
9999
TEST_PECO_SPOG_WORKSPACE_ID: ${{ secrets.TEST_PECO_SPOG_WORKSPACE_ID }}
100100
TEST_PECO_UC_CLUSTER_ID: ${{ secrets.TEST_PECO_UC_CLUSTER_ID }}
101+
TEST_PECO_SPOG_NATIVE: "1"
101102
UV_FROZEN: "1"
102103
steps:
103104
- name: Check out repository
@@ -184,6 +185,7 @@ jobs:
184185
DBT_DATABRICKS_LOCATION_ROOT: ${{ secrets.TEST_PECO_EXTERNAL_LOCATION }}test
185186
TEST_PECO_SPOG_WORKSPACE_ID: ${{ secrets.TEST_PECO_SPOG_WORKSPACE_ID }}
186187
TEST_PECO_UC_CLUSTER_ID: ${{ secrets.TEST_PECO_UC_CLUSTER_ID }}
188+
TEST_PECO_SPOG_NATIVE: "1"
187189
UV_FROZEN: "1"
188190
steps:
189191
- name: Check out repository
@@ -268,7 +270,7 @@ jobs:
268270
DBT_DATABRICKS_LOCATION_ROOT: ${{ secrets.TEST_PECO_EXTERNAL_LOCATION }}test
269271
TEST_PECO_SPOG_WORKSPACE_ID: ${{ secrets.TEST_PECO_SPOG_WORKSPACE_ID }}
270272
TEST_PECO_CLUSTER_ID: ${{ secrets.TEST_PECO_CLUSTER_ID }}
271-
TEST_PECO_UC_CLUSTER_ID: ${{ secrets.TEST_PECO_UC_CLUSTER_ID }}
273+
TEST_PECO_SPOG_NATIVE: "1"
272274
UV_FROZEN: "1"
273275
steps:
274276
- name: Check out repository

tests/functional/adapter/spog/conftest.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,16 @@
1212

1313

1414
@pytest.fixture(scope="session", autouse=True)
15-
def _require_spog_deps():
15+
def _require_spog_test_env():
1616
if not (connector_supports_spog() and sdk_supports_workspace_id()):
1717
pytest.skip(
1818
"SPOG functional tests require databricks-sdk and databricks-sql-connector "
1919
"with SPOG support installed."
2020
)
21+
if os.getenv("TEST_PECO_SPOG_NATIVE") == "1":
22+
pytest.skip(
23+
"SPOG override tests are redundant on a SPOG-native profile."
24+
)
2125

2226

2327
def _workspace_id() -> str:
@@ -34,7 +38,7 @@ def _spog_host() -> str:
3438
can still exercise SPOG routing. Falls back to DBT_DATABRICKS_HOST_NAME,
3539
which the SPOG-specific workflow already sets to a SPOG vanity URL.
3640
"""
37-
host = os.getenv("TEST_PECO_SPOG_HOST") or os.getenv("DBT_DATABRICKS_HOST_NAME")
41+
host = os.getenv("TEST_PECO_SPOG_HOST")
3842
if not host:
3943
raise RuntimeError(
4044
"SPOG functional tests require TEST_PECO_SPOG_HOST or DBT_DATABRICKS_HOST_NAME."

tests/functional/adapter/spog/test_spog_connection_open.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ def test_probe_failure_run_succeeds(self, project):
3232
run_dbt(["run", "--select", "spog_smoke_model"], expect_pass=True)
3333

3434

35+
@pytest.mark.skip_profile("databricks_cluster", "databricks_uc_cluster")
3536
class TestSpogNamedCompute:
3637
@pytest.fixture(scope="class")
3738
def models(self):

0 commit comments

Comments
 (0)