fix: auto-quote backtick-rendered refs in metric_view YAML body (#1361)#1430
Open
sd-db wants to merge 2 commits into1.12.latestfrom
Open
fix: auto-quote backtick-rendered refs in metric_view YAML body (#1361)#1430sd-db wants to merge 2 commits into1.12.latestfrom
sd-db wants to merge 2 commits into1.12.latestfrom
Conversation
Bare `{{ ref(...) }}` in a metric_view source: line rendered to
`db`.`schema`.`name` and broke the YAML scanner with
METRIC_VIEW_INVALID_VIEW_DEFINITION. Wrap such values in YAML double
quotes before embedding the body, preserving SQL identifier escaping.
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
Collaborator
Author
|
/integration-test |
|
Integration tests dispatched for PR #1430 by @sd-db. Track progress in the Actions tab. |
|
Integration results for PR #1430 — UC cluster ✅ success · SQL warehouse ✅ success · All-purpose cluster ✅ success |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1361.
Bug
Bare
{{ ref('x') }}in ametric_viewsource:field renders to`db`.`schema`.`x`, which the YAML scanner rejects:Fix
Add
SqlUtils.yaml_quote_backtick_values— wraps backtick-rendered identifiers in mapping values with"..."before the body is embedded in$$..$$. Preserves SQL identifier escaping for non-trivial names (hyphens, reserved words). Called from the metric_view create and alter macros.Same shape as
SqlUtils.clean_sqland theSTREAMstrip instreaming_table/create.sql.Test plan
tests/unit/test_handle.py) — idempotence, multi-line, indented, inline backticks left alone, etc.TestMetricViewBareRefruns a bare-ref metric_view + round-trips aMEASURE()querytests/functional/adapter/metric_views/suite (18 tests) — no regressionspre-commit run --all-filesclean