From dd62f941cefcda5d20ce3877db34527a48eecd44 Mon Sep 17 00:00:00 2001 From: Eric Jang Date: Wed, 28 May 2025 12:21:45 -0700 Subject: [PATCH 1/2] Fix integration tests --- .../simple_snapshot/test_various_configs.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/functional/adapter/simple_snapshot/test_various_configs.py b/tests/functional/adapter/simple_snapshot/test_various_configs.py index 18b82de00..6bbfb9197 100644 --- a/tests/functional/adapter/simple_snapshot/test_various_configs.py +++ b/tests/functional/adapter/simple_snapshot/test_various_configs.py @@ -60,7 +60,7 @@ def text_replace(input: str) -> str: invalidate_sql_2 = """ -- invalidate records 11 - 21 update {schema}.snapshot_expected set - test_valid_to = updated_at + interval '1 hour' + TEST_VALID_TO = updated_at + interval '1 hour' where id >= 10 and id <= 20; """ @@ -75,7 +75,7 @@ def text_replace(input: str) -> str: invalidate_multi_key_sql_2 = """ -- invalidate records 11 - 21 update {schema}.snapshot_expected set - test_valid_to = updated_at + interval '1 hour' + TEST_VALID_TO = updated_at + interval '1 hour' where id1 >= 10 and id1 <= 20; """ @@ -129,7 +129,7 @@ def project_config_update(self): "snapshots": { "test": { "+snapshot_meta_column_names": { - "dbt_valid_to": "test_valid_to", + "dbt_valid_to": "TEST_VALID_TO", "dbt_valid_from": "test_valid_from", "dbt_scd_id": "test_scd_id", "dbt_updated_at": "test_updated_at", @@ -175,7 +175,7 @@ def project_config_update(self): "snapshots": { "test": { "+snapshot_meta_column_names": { - "dbt_valid_to": "test_valid_to", + "dbt_valid_to": "TEST_VALID_TO", "dbt_valid_from": "test_valid_from", "dbt_scd_id": "test_scd_id", "dbt_updated_at": "test_updated_at", @@ -195,7 +195,7 @@ def test_snapshot_invalid_column_names(self, project): manifest = get_manifest(project.project_root) snapshot_node = manifest.nodes["snapshot.test.snapshot_actual"] snapshot_node.config.snapshot_meta_column_names == { - "dbt_valid_to": "test_valid_to", + "dbt_valid_to": "TEST_VALID_TO", "dbt_valid_from": "test_valid_from", "dbt_scd_id": "test_scd_id", "dbt_updated_at": "test_updated_at", @@ -210,7 +210,7 @@ def test_snapshot_invalid_column_names(self, project): "snapshots": { "test": { "+snapshot_meta_column_names": { - "dbt_valid_to": "test_valid_to", + "dbt_valid_to": "TEST_VALID_TO", "dbt_updated_at": "test_updated_at", } } @@ -236,7 +236,7 @@ def models(self): "ref_snapshot.sql": ref_snapshot_sql, } - def test_valid_to_current(self, project): + def TEST_VALID_TO_current(self, project): project.run_sql(create_seed_sql) project.run_sql(create_snapshot_expected_sql) project.run_sql(seed_insert_sql) @@ -247,7 +247,7 @@ def test_valid_to_current(self, project): original_snapshot: Table = run_sql_with_adapter( project.adapter, - "select id, test_scd_id, test_valid_to from {schema}.snapshot_actual", + "select id, test_scd_id, TEST_VALID_TO from {schema}.snapshot_actual", "all", ) assert original_snapshot[0][2] == datetime.datetime( @@ -269,7 +269,7 @@ def test_valid_to_current(self, project): updated_snapshot: Table = run_sql_with_adapter( project.adapter, - "select id, test_scd_id, test_valid_to from {schema}.snapshot_actual", + "select id, test_scd_id, TEST_VALID_TO from {schema}.snapshot_actual", "all", ) print(updated_snapshot) From 1314e545c17b5f75618df0423d59968a111d00d7 Mon Sep 17 00:00:00 2001 From: Eric Jang Date: Wed, 28 May 2025 12:22:56 -0700 Subject: [PATCH 2/2] unnecessary change --- .../functional/adapter/simple_snapshot/test_various_configs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/functional/adapter/simple_snapshot/test_various_configs.py b/tests/functional/adapter/simple_snapshot/test_various_configs.py index 6bbfb9197..c155c1c96 100644 --- a/tests/functional/adapter/simple_snapshot/test_various_configs.py +++ b/tests/functional/adapter/simple_snapshot/test_various_configs.py @@ -236,7 +236,7 @@ def models(self): "ref_snapshot.sql": ref_snapshot_sql, } - def TEST_VALID_TO_current(self, project): + def test_valid_to_current(self, project): project.run_sql(create_seed_sql) project.run_sql(create_snapshot_expected_sql) project.run_sql(seed_insert_sql)