fix: warm cache pre-commit and uv cache path bugs#1389
Open
Conversation
Two bugs from the initial warm cache workflow: 1. pre-commit is inside hatch's default env, not on system PATH. Changed to: hatch run pre-commit install-hooks 2. setup-uv overrides UV_CACHE_DIR to a temp path, but cache save/restore uses ~/.cache/uv. Pin UV_CACHE_DIR in job env so setup-uv respects it and paths align.
Coverage report
This PR does not seem to contain any modification to coverable code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pre-commit: command not foundin warmDepsCache — pre-commit is inside hatch's default env, usehatch run pre-commit install-hookssetup-uvoverridesUV_CACHE_DIRto a temp path, but cache save/restore uses~/.cache/uv. PinUV_CACHE_DIR: /home/runner/.cache/uvin job env sosetup-uvrespects it and paths align.Test plan