test: UTF-8 round-trip regression for dbt seed#1416
Merged
Conversation
Seeds a CSV containing Arabic, Greek, Chinese, emoji, and accented Latin then asserts each cell round-trips byte-exact through the seed path. Covers both V1 and V2 materialization. Guards the fix for #332, which reported non-ASCII characters being mangled on seed in 1.4.x. The current parameterized-insert path (adapter.add_query + bindings) handles UTF-8 correctly; this test locks that in. Co-authored-by: Isaac
Coverage report
This PR does not seem to contain any modification to coverable code. |
Co-authored-by: Isaac
tejassp-db
reviewed
Apr 24, 2026
Collaborator
tejassp-db
left a comment
tejassp-db
left a comment
There was a problem hiding this comment.
Is it possible to use the exact words mentioned in the issue?#332
Words from this image - https://user-images.githubusercontent.com/11973991/235822152-baedfa2c-81d6-4d22-9789-afbed5184e97.png
Collaborator
Author
We need to do overall UTF support testing, in that regards I would say the current test is good enough and has enough coverage. We do not need to use the exact same words described in the issue |
tejassp-db
approved these changes
Apr 27, 2026
|
Thanks for resolving! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a functional test that seeds a CSV containing Arabic, Greek, Chinese, emoji, and accented Latin, then asserts every cell round-trips byte-exact through the seed path. Covers both V1 and V2 materialization.
This guards the fix for #332 (non-ASCII characters being mangled on seed, reported against 1.4.3). The current parameterized-insert path (
adapter.add_query(sql, bindings=bindings, ...)indbt/include/databricks/macros/materializations/seeds/helpers.sql) handles UTF-8 correctly — this test locks that in.Test plan
hatch run pytest tests/functional/adapter/simple_seed/test_utf8_seed.py -v— 2 passed in ~36s against a live Databricks cluster (V1 + V2)Closes #332.
This pull request and its description were written by Isaac.