fix: missing metadata handling in is_hudi and is_iceberg#1435
Open
aarushisingh04 wants to merge 2 commits intodatabricks:mainfrom
Open
fix: missing metadata handling in is_hudi and is_iceberg#1435aarushisingh04 wants to merge 2 commits intodatabricks:mainfrom
aarushisingh04 wants to merge 2 commits intodatabricks:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
description
can_be_replacedcallsis_icebergwithout first checking whether metadata is available. on relations that haven't fetched extended metadata yet (metadata=None) this hits an unconditionalassert self.metadata is not Noneand crashes the dbt run with anAssertionError.the fix
is_hudiandis_icebergto safely returnFalsewhenself.metadata is None, making their behavior consistent with other metadata properties likeownerandstats.checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.