Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

### Fixes

- Fix latent AssertionError when evaluating `is_hudi` or `is_iceberg` properties on relations without metadata
- Validate relation identifier length at creation time and raise a clear error when it exceeds Databricks' 255-character limit ([#1309](https://github.com/databricks/dbt-databricks/issues/1309))
- Fix spurious `MicrobatchConcurrency` behavior-change warning firing on every run regardless of whether the project contained microbatch models ([#1406](https://github.com/databricks/dbt-databricks/issues/1406))
- Fix DBR capability cache being permanently poisoned by a transient version-query failure ([#1398](https://github.com/databricks/dbt-databricks/issues/1398))
Expand Down
6 changes: 2 additions & 4 deletions dbt/adapters/databricks/relation.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,13 +146,11 @@ def is_dlt(self) -> bool:

@property
def is_hudi(self) -> bool:
assert self.metadata is not None
return self.metadata.get(KEY_TABLE_PROVIDER) == "hudi"
return self.metadata is not None and self.metadata.get(KEY_TABLE_PROVIDER) == "hudi"

@property
def is_iceberg(self) -> bool:
assert self.metadata is not None
return self.metadata.get(KEY_TABLE_PROVIDER) == "iceberg"
return self.metadata is not None and self.metadata.get(KEY_TABLE_PROVIDER) == "iceberg"

@property
def owner(self) -> Optional[str]:
Expand Down
16 changes: 16 additions & 0 deletions tests/unit/test_relation.py
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,22 @@ def test_is_iceberg_false_for_delta(self):
)
assert relation.is_iceberg is False

def test_is_iceberg_no_metadata(self):
relation = DatabricksRelation.create(
identifier="no_metadata_iceberg_table",
type="table",
metadata=None,
)
assert relation.is_iceberg is False

def test_is_hudi_no_metadata(self):
relation = DatabricksRelation.create(
identifier="no_metadata_hudi_table",
type="table",
metadata=None,
)
assert relation.is_hudi is False

@pytest.mark.parametrize(
"type_, is_delta, is_iceberg, expected_can_be_replaced",
[
Expand Down