fix: gate column-level constraints on contract.enforced (#1381)#1470
Merged
Conversation
`adapter.parse_columns_and_constraints` gains a `contract_enforced` flag so the column-level subpath honors the same gate that already applies to the model-level subpath and the diff path. The three V2 create macros (`table`, `materialized_view`, `streaming_table`) compute `contract.enforced` once and pass it in. Pre-fix, under `use_materialization_v2: true` without `contract.enforced: true`, column-level NOT NULL / FK leaked through and were applied to the table, while model-level constraints (e.g. multi-column PK) were correctly gated out. On incremental re-runs the diff path then "cleaned up" the leaked constraints, emitting `DROP CONSTRAINT IF EXISTS` with no follow-up `ADD CONSTRAINT` — silently stripping constraints on every successive run. Closes #1381. Completes the contract-enforcement work from #1342/#1343.
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Collaborator
Author
|
/integration-test |
|
Integration tests dispatched for PR #1470 by @sd-db. Track progress in the Actions tab. |
|
Integration results for PR #1470 — UC cluster ✅ success · SQL warehouse ❌ failure · All-purpose cluster ✅ success · Shard coverage ✅ success |
The not_null on id was being applied silently via the pre-PR leak. With column-level constraints now gated by contract.enforced, the fixture must opt in explicitly to keep test_streaming_table_create asserting that the constraint reaches the database. Mirrors the existing materialized_view_schema fixture.
jprakash-db
approved these changes
May 21, 2026
jprakash-db
left a comment
jprakash-db
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thanks for making the changes
When a model declares column-level constraints but does not set contract.enforced: true, parse_columns_and_constraints now emits a targeted info-level log naming the model, instead of silently dropping the constraints. Fires only when constraints are actually declared, so it stays quiet for models without constraints or with enforcement on. Threads model.name through the three V2 create macros (table, materialized_view, streaming_table).
…onstraint-leak # Conflicts: # CHANGELOG.md
- Drop redundant log-message assertion in the skip-logs test; assert_called_once() is sufficient. - Remove the info-log note from the BREAKING changelog line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1381. Completes the contract-enforcement work from #1342 / #1343 for the column-level subpath.
Under
use_materialization_v2: truewithoutcontract.enforced: true, the macro-layer gate stripped model-level constraints but left column-level ones untouched — they flowed throughparse_columns_and_constraintsintoCREATE TABLEBreaking for anyone relying on the leak — column-level NOT NULL / PK / FK on V2 now requires
contract.enforced: true. Called out in CHANGELOG.Test plan
TestParseColumnsAndConstraintsGateintests/unit/test_constraints.py(4 cases)tests/functional/adapter/constraints/test_column_constraint_gate.py— gated and ungated paths against a live cluster