Skip to content

fix: raise DbtRuntimeError when job run terminates with non-success result state #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dev-X25874 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: raise DbtRuntimeError when job run terminates with non-success result state #1477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4a11ca
api_client: raise error when job run terminates with non-success resu…
Dev-X25874 May 23, 2026
bba823f
tests/unit/api_client: add test for TERMINATED+FAILED poll_for_comple…
Dev-X25874 May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions dbt/adapters/databricks/api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,11 @@ def _handle_terminal_state(self, run: Run) -> None:
self._handle_non_terminated_failure(
run, life_cycle_state, state_message, result_state or ""
)
elif result_state not in (None, "SUCCESS", "SUCCESS_WITH_FAILURES"):
raise DbtRuntimeError(
f"Python model run ended in result_state {result_state}"
f" (run_id: {run.run_id})\nState message: {state_message}"
)

def cancel(self, run_id: str) -> None:
logger.debug(f"Cancelling run id {run_id}")
Expand Down
17 changes: 17 additions & 0 deletions tests/unit/api_client/test_job_runs_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,3 +203,20 @@ def test_poll_for_completion__success(self, _, api, workspace_client):
api.poll_for_completion("123")

workspace_client.jobs.get_run.assert_called_with(run_id=123)

@freezegun.freeze_time("2020-01-01")
@patch("time.sleep")
def test_poll_for_completion__failed(self, _, api, workspace_client):
mock_run = Mock(spec=Run)
mock_state = Mock(spec=RunState)
mock_state.life_cycle_state = RunLifeCycleState.TERMINATED
mock_state.result_state = RunResultState.FAILED
mock_state.state_message = "notebook raised exception"
mock_run.state = mock_state
mock_run.run_id = 123
workspace_client.jobs.get_run.return_value = mock_run

with pytest.raises(DbtRuntimeError) as exc:
api.poll_for_completion("123")

assert "Python model run ended in result_state FAILED" in str(exc.value)