refactor: remove Unity Catalog conditionals — UC is the only model registry#221
Open
veenaramesh wants to merge 5 commits into
Open
refactor: remove Unity Catalog conditionals — UC is the only model registry#221veenaramesh wants to merge 5 commits into
veenaramesh wants to merge 5 commits into
Conversation
Move all Databricks notebooks out of nested notebooks/ subdirectories to sit alongside their sibling helper modules. This eliminates the %cd .. hacks that were needed to import from parent directories and simplifies the project layout for a data science workflow. Moves: - training/notebooks/*.py → training/*.py - validation/notebooks/ModelValidation.py → validation/ModelValidation.py - deployment/*/notebooks/*.py → deployment/*/*.py - feature_engineering/notebooks/*.py → feature_engineering/*.py - monitoring/notebooks/*.py → monitoring/*.py Updates all resource YAMLs, update_layout.tmpl, and README references. Co-authored-by: Isaac
Databricks bundle deployments set the notebook CWD correctly, so the notebook_path/%cd $notebook_path pattern is unnecessary. Sibling imports work naturally after the flatten-notebooks change. Also inlines the trivial get_deployed_model_stage_for_env helper (a dict lookup) to eliminate cross-directory sys.path.append in deploy.py and BatchInference.py. Co-authored-by: Isaac
No longer needed with databricks bundle init. Co-authored-by: Isaac
Unity Catalog is now the only supported model registry. This removes all conditional branching on input_include_models_in_unity_catalog, hardcoding the UC=yes path throughout: - Force UC=yes in databricks_template_schema.json and skip the prompt - Simplify skip_prompt_if for catalog/schema/user group fields - Remove workspace model registry code paths from all notebooks - Remove get_deployed_model_stage_for_env from utils.py - Always include catalog_name variable in databricks.yml targets - Use registered_models (not models) in ml-artifacts-resource.yml - Use UC table names in all workflow resource configs - Remove non-UC deploy path (stage transitions) from deploy.py - Remove workspace registry links/references from docs - Always skip utils.py in update_layout.tmpl Co-authored-by: Isaac
The mlflow.recipes module no longer exists in MLflow 3.x, causing test collection to fail with ModuleNotFoundError. Co-authored-by: Isaac
veenaramesh
force-pushed
the
refactor/remove-uc-conditionals
branch
from
1f2fbdb to
5eede46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
input_include_models_in_unity_catalogparameter from schema, tests, and configsutils.py(workspace model stage helper, no longer needed)Depends on #219 (simplify-project-structure).
Test plan
databricks bundle initno longer prompts for Unity Catalog model registry choice