[Fix] Reject workspace_id with a leading zero in provider_config#5763
Draft
tanmay-db wants to merge 1 commit into
Draft
[Fix] Reject workspace_id with a leading zero in provider_config#5763tanmay-db wants to merge 1 commit into
tanmay-db wants to merge 1 commit into
Conversation
A provider_config.workspace_id like "0470576644108500" passed the StringIsNotEmpty validation and, because strconv.ParseInt tolerates leading zeros, routed to the correct workspace. But the literal padded value was written verbatim to state, where it no longer matched the canonical numeric ID returned by the API, poisoning every downstream string comparison (perpetual diffs, failed workspace_id reconciliation, spurious ForceNew). workspaceIDValidateFunc now rejects all-digit values with a leading zero and suggests the canonical form, while leaving non-numeric connection IDs untouched so the platform gateway can still disambiguate them server-side. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A provider_config.workspace_id like "0470576644108500" passed the StringIsNotEmpty validation and, because strconv.ParseInt tolerates leading zeros, routed to the correct workspace. But the literal padded value was written verbatim to state, where it no longer matched the canonical numeric ID returned by the API, poisoning every downstream string comparison (perpetual diffs, failed workspace_id reconciliation, spurious ForceNew).
workspaceIDValidateFunc now rejects all-digit values with a leading zero and suggests the canonical form, while leaving non-numeric connection IDs untouched so the platform gateway can still disambiguate them server-side.
Co-authored-by: Isaac
Changes
Tests
make testrun locallydocs/folderinternal/acceptanceNEXT_CHANGELOG.mdfile