pipelines: don't send edition/channel for ingestion pipelines#5783
Draft
shreyas-goenka wants to merge 3 commits into
Draft
pipelines: don't send edition/channel for ingestion pipelines#5783shreyas-goenka wants to merge 3 commits into
shreyas-goenka wants to merge 3 commits into
Conversation
Ingestion pipelines (those with ingestion_definition) use serverless compute by default. The API rejects edition and channel as incompatible cluster settings in that mode. The schema defaults remain in place so the plan still shows the correct defaults for regular DLT pipelines. The Create and Update functions now clear these fields before the API call when ingestion_definition is set. Co-authored-by: Shreyas Goenka <shreyas.goenka@databricks.com>
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
|
Please ensure that the NEXT_CHANGELOG.md file is updated with any relevant changes. |
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
The SDK's Serverless field is a bool with omitempty, so a false value is dropped unless "Serverless" is in ForceSendFields. Call SetForceSendFields in Create and Update so that an explicitly-set serverless = false is serialized and sent to the platform. Co-authored-by: Shreyas Goenka <shreyas.goenka@databricks.com>
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
GetOkExists reads from both state and config (level "set"), so it returns true whenever serverless=false exists in state — even for users who never set serverless in their config. This means SetForceSendFields would fire for existing classic compute pipelines on every apply, a broader behavior change than intended. Reverting until the correct approach is determined. Co-authored-by: Shreyas Goenka <shreyas.goenka@databricks.com>
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LakeFlow Connect ingestion pipelines fail with:
Two root causes:
CustomizeSchemaunconditionally setsedition = ADVANCEDandchannel = CURRENTfor all pipeline types. The API rejects these as cluster settings for ingestion pipelines, which default to serverless compute.serverless = falsewas silently dropped — the SDK'sServerless boolfield hasomitempty, so a false value is never sent unless"Serverless"is inForceSendFields.Fix
In
CreateandUpdate:editionandchannelwhen the pipeline has aningestion_definition.SetForceSendFieldsfor"serverless"so that an explicitly-setserverless = falseis serialized and sent to the API.