Grouping verify#5784
Draft
tanmay-db wants to merge 3 commits into
Draft
Conversation
Move SDKv2 resource and data source registration out of sdkv2.go into a new resources.go, split into Workspace*, Account*, and Dual* maps. sdkv2.go now calls Resources() / DataSources(), which flatten the three maps via merge. This is an organizational change with no runtime effect today. Add TestApiField_RegistrationConsistency asserting that every Dual* entry carries the "api" schema attribute (the single signal that a resource is dual, set by common.AddApiField) and every Workspace*/Account* entry does not. Co-authored-by: Isaac
…tion tests TestProviderConfig_AccountRegistrationConsistency asserts that account resources and data sources do not carry the provider_config block (they have no workspace context), pinning the two deprecated account-only data sources that retain it for backward compatibility. TestNoDuplicateKeys asserts that no Terraform name is registered in more than one of the Workspace*/Account*/Dual* maps within a namespace; the split into three maps removed the compile-time duplicate-key guarantee a single map literal provided. Co-authored-by: Isaac
Verification-branch-only golden snapshot: goldenDataSources/goldenResources are copied verbatim from main's pre-split sdkv2.go. TestRegistration_NoDriftFromPreSplit asserts Resources()/DataSources() register the exact same keys and that each key maps to a resource with the same schema fingerprint (catches accidental add, remove, or remap). Not intended to merge. Co-authored-by: Isaac
Contributor
|
Please ensure that the NEXT_CHANGELOG.md file is updated with any relevant changes. |
Contributor
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Tests
make testrun locallydocs/folderinternal/acceptanceNEXT_CHANGELOG.mdfile