You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
configure skills: utility-tools-only mode, announce registration, restart hint (#248)
* configure skills: utility-tools-only mode, announce registration, restart hint
Addresses three bug-bash P0 gaps in `ucode configure skills`:
- Make `--location` optional. A bare `ucode configure skills` (or `--mcp` with
no location) now registers the schema-less skills MCP connection — the
cross-schema utility tools only — without forcing a download. `--path`
without `--location` is rejected.
- Announce the registration: print the server name, URL, configured agents, and
a tool-category one-liner (utility tools, plus live per-schema skill tools
when scoped). Download mode also prints where files landed. The summary names
categories, not individual tools, so it can't drift when the backend changes
its offering.
- Always end with a launch/restart line ("Run `ucode <agent>` ...; existing
sessions need a restart"), and note that downloaded files already work from
disk. The summary prints even on a no-op re-run; only the save is gated on a
real change.
Co-authored-by: Isaac
* Address review comments
- mcp.py: drop the download-specific restart clause; rename `_join_human` to
`_join_with_and`; tighten `_print_skills_summary` docstring and restore the
original `_update_skills_mcp` docstring; rename the local `displays` to
`clients`; remove the now-unused `download_roots` plumbing and `Path` import.
- Drop "live" from the tools summary line.
- skills_download.py: fold the download roots into the per-location summary
("Downloaded N/M skill(s) from `x.y` in <roots>") instead of a separate note.
- README / status hint: reword the skills copy.
- Tests: assert the full summary strings (not substrings); update the download
summary + dispatch tests accordingly.
Co-authored-by: Isaac
* Address review comments: rename tools helper, add status markers
- Rename `_skills_tools_summary` to `_skills_tools_description` and drop its
docstring (the function is self-explanatory).
- Prefix the summary heading with ✔ and the restart note with ⚠.
Co-authored-by: Isaac
* Drop the ⚠ marker from the restart note
Keep the plain `print_note` bullet for the restart line; the ✔ heading stays.
Co-authored-by: Isaac
* Drop the redundant "Saved" line from the skills summary
The `✔ Skills MCP registered` summary heading now serves as the confirmation,
so the separate `✔ Saved` line was printing two checkmarks for one action.
Co-authored-by: Isaac
* Address review comments: reword skills docstring and restart note
- Restructure the `configure_skills` docstring around whether `--location` is
given, then whether `--mcp` is present.
- Reword the restart note to "restart the agent for the skills to take effect".
Co-authored-by: Isaac
* Clarify download-path docstring wording
The download path registers the MCP connection with utility tools only.
Co-authored-by: Isaac
* Match the summary checkmark color and space the download line
- Color the summary heading's ✔ green so it matches the green ✔ from
`print_success` on the download line (the heading's bold-wrap was rendering
it white).
- Print a blank line before each per-location "Downloaded ..." line.
Co-authored-by: Isaac
* Use print_success for the skills summary heading
Replace the manually-greened print_heading with print_success so the summary
heading's ✔ matches the download line's checkmark (both green, no bold-wrap or
inline color markup). Keep the leading blank line for spacing.
Co-authored-by: Isaac
Copy file name to clipboardExpand all lines: AGENTS.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -20,7 +20,7 @@ Tests live in `tests/`.
20
20
21
21
- Use Python 3.12+.
22
22
- Keep changes scoped to the requested behavior.
23
-
- Follow the existing module boundaries: CLI orchestration in `cli.py`, agent-specific behavior in `agents/<name>.py`, shared agent dispatch in `agents/__init__.py`, Databricks calls in `databricks.py`, skill download (UC fetch client + on-disk writer + download orchestration) in `skills_download.py`, MCP-connection state glue in `mcp.py`, and presentation helpers in `ui.py`. Skill download persists no disk state — it writes files to `--path` (or the home dir) and registers only the schema-less skills MCP connection.
23
+
- Follow the existing module boundaries: CLI orchestration in `cli.py`, agent-specific behavior in `agents/<name>.py`, shared agent dispatch in `agents/__init__.py`, Databricks calls in `databricks.py`, skill download (UC fetch client + on-disk writer + download orchestration) in `skills_download.py`, MCP-connection state glue in `mcp.py`, and presentation helpers in `ui.py`. Skill download persists no disk state — it writes files to `--path` (or the home dir) and registers only the schema-less skills MCP connection.`ucode configure skills` with no `--location` (or `--mcp` with no `--location`) registers that schema-less connection without downloading anything.
24
24
- Prefer existing helpers for config file writes, state persistence, UI messages, and Databricks authentication.
25
25
- Add or update focused tests for behavior changes.
26
26
- Do not modify generated or lock files unless the dependency graph intentionally changes.
|`ucode configure --profiles DEFAULT --use-pat`| Authenticate with the profile's personal access token — no browser login |
152
159
|`ucode configure --skip-validate`| Write configs without sending a test message through each agent |
153
160
|`ucode configure --agents claude --mcp system.ai.slack`| Configure an agent and register its Databricks MCP server(s) in one command |
161
+
|`ucode configure skills`| Register the skills MCP connection (utility tools only); no skills download |
154
162
|`ucode configure skills --location main.default [--path <dir>]`| Download a schema's skills to disk (under `<dir>`, or your home dir) and register a schema-less skills MCP connection |
155
163
|`ucode configure skills --location main.default --mcp`| Expose a schema's skills as MCP tools (override-only) instead of downloading |
0 commit comments