Skip to content

Fix wheel and sdist build configuration#377

Merged
asnare merged 4 commits into
mainfrom
fix_wheel
May 7, 2026
Merged

Fix wheel and sdist build configuration#377
asnare merged 4 commits into
mainfrom
fix_wheel

Conversation

@mwojtyczka
Copy link
Copy Markdown
Contributor

@mwojtyczka mwojtyczka commented Apr 21, 2026

Summary

Build artifacts is broken after switching from hatch to uv: the wheel is coming out empty, and the sdist is unpacked into a src/ directory instead of a clean project layout.

Split the Hatch config into per-target sections:

  • [tool.hatch.build.targets.wheel] — sets packages = ["src/databricks"] so the databricks.labs.blueprint package is actually included in the wheel.
  • [tool.hatch.build.targets.sdist] — uses only-include = ["src", "README.md", "LICENSE", "NOTICE"] so the sdist contains the source tree and metadata at the top level.

Test plan

  • uv build produces a non-empty wheel containing databricks/labs/blueprint/...
  • sdist unpacks with src/, README.md, LICENSE, NOTICE at the top level
  • pip install the wheel in a fresh venv and import databricks.labs.blueprint succeeds

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

✅ 40/40 passed, 2 skipped, 1m58s total

Running from acceptance #433

@asnare asnare self-assigned this Apr 22, 2026
@asnare asnare added bug Something isn't working internal do not show this PR in changelog labels Apr 22, 2026
@asnare asnare added this to UCX Apr 22, 2026
@asnare asnare moved this to Ready for Review in UCX Apr 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.15%. Comparing base (51e52cd) to head (e2537fb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #377   +/-   ##
=======================================
  Coverage   80.15%   80.15%           
=======================================
  Files          17       17           
  Lines        2474     2474           
  Branches      403      403           
=======================================
  Hits         1983     1983           
  Misses        364      364           
  Partials      127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@asnare asnare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for flagging the problem. It took me a while to get back to this, and indeed it was a coincidence that it previously worked with hatch.

@asnare asnare merged commit 906d6fc into main May 7, 2026
14 checks passed
@asnare asnare deleted the fix_wheel branch May 7, 2026 12:19
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in UCX May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working internal do not show this PR in changelog

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants