Skip to content

Commit dd47d9c

Browse files
authored
Merge pull request #7 from vivek-biradar/fix_bounds_failed_status
Fix Failed Status for Bounds in case of Non Aggregate Rule
2 parents 0fd861d + 8da107b commit dd47d9c

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

src/main/scala/com/databricks/labs/validation/Validator.scala

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,13 @@ class Validator(ruleSet: RuleSet, detailLvl: Int) extends SparkSessionWrapper {
103103
rule.ruleType match {
104104
case "bounds" =>
105105
val invalid = rule.inputColumn < rule.boundaries.lower || rule.inputColumn > rule.boundaries.upper
106-
val failed = when(
107-
col(rule.ruleName) < rule.boundaries.lower || col(rule.ruleName) > rule.boundaries.upper, true)
108-
.otherwise(false).alias("Failed")
106+
val failed = if (rule.isAgg) {
107+
when(
108+
col(rule.ruleName) < rule.boundaries.lower || col(rule.ruleName) > rule.boundaries.upper, true)
109+
.otherwise(false).alias("Failed")
110+
} else{
111+
when(col(rule.ruleName) > 0,true).otherwise(false).alias("Failed")
112+
}
109113
val first = if (!rule.isAgg) { // Not Agg
110114
sum(when(invalid, 1).otherwise(0)).alias(rule.ruleName)
111115
} else { // Is Agg

0 commit comments

Comments
 (0)