-
Notifications
You must be signed in to change notification settings - Fork 112
feat: add variable substitution support for check definitions #1078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mwojtyczka
merged 31 commits into
databrickslabs:main
from
fedeflowers:feature/parametrization_rules
Apr 22, 2026
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
9e35d35
feat: add variable substitution support for check definitions
fedeflowers ecc09c2
Apply suggestions from code review
fedeflowers 870afe6
add variables param in contracts apply_checks_by_metadata, apply_chec…
fedeflowers 877e748
add change to parametrize variables from load_checks instead of apply…
fedeflowers 0a1899f
Merge branch 'main' into feature/parametrization_rules
mwojtyczka a3a78de
Restore test_apply_checks_by_metadata_and_save_in_table_loads_checks_…
mwojtyczka b896032
add EXTRA_PARAMS compatibility, added unit and integrations tests for…
fedeflowers c1ff146
add test parametrization variables, checked col is missing and anothe…
fedeflowers b25a510
Merge branch 'main' into feature/parametrization_rules
mwojtyczka 1213a01
Merge branch 'main' into feature/parametrization_rules
mwojtyczka 100c9cf
fix tests for variable parametrization of core on load checks, revert…
fedeflowers e2e1f1e
fix reverted extra space on apply checks in table file
fedeflowers 4e3a81d
add docs, fix overloading, deduplication of tests, removed integratio…
fedeflowers 7fdd172
add docs for variable parametrization, fix dqx demo
fedeflowers a3a21a6
fix tests duplication
fedeflowers 908873c
fix test readded test_extra_params_variables_substitution_and_overrid…
fedeflowers 4446b52
add doc warnign and test with empty dictionary
fedeflowers 8a9eb79
Update docs and fmt
ghanse be8c556
Merge branch 'main' into feature/parametrization_rules
mwojtyczka ffd982a
Apply suggestion from @mwojtyczka
mwojtyczka 1eae942
Apply suggestions from code review
mwojtyczka a30271b
added tests
mwojtyczka 07a0968
added vars resolution when saving checks and discourage using vars fo…
mwojtyczka 55d4e1f
updated tests
mwojtyczka 6b8687b
fix docs
mwojtyczka aa4883c
fixed ci
mwojtyczka b6fdb8c
fix CI
mwojtyczka 5b12453
Merge branch 'main' into feature/parametrization_rules
mwojtyczka c45a260
Merge branch 'main' into feature/parametrization_rules
mwojtyczka 77d2db4
Merge branch 'main' into feature/parametrization_rules
mwojtyczka 6811258
fmt
mwojtyczka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.