App MVP#1090
Merged
mwojtyczka merged 52 commits intomainfrom Apr 30, 2026
Merged
Conversation
Contributor
|
✅ 722/722 passed, 1 flaky, 39 skipped, 5h20m41s total Flaky tests:
Running from acceptance #4537 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1090 +/- ##
==========================================
+ Coverage 91.86% 92.11% +0.25%
==========================================
Files 101 101
Lines 9546 9546
==========================================
+ Hits 8769 8793 +24
+ Misses 777 753 -24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Few issues to sort outstanding |
…into feature/app-refactor
…r, and streamline docs - Allow VIEWER role to access run history (dryrun.py) - Fix tmp schema creation to use SP credentials instead of user OBO token, preventing PERMISSION_DENIED for non-admin users on dry run - Fix sql_expression checks treating col_name '*' as a literal column, which disabled all tables in the target table picker - Add job retry config (max_retries: 1) to task runner in databricks.yml - Grant USE CATALOG to account users at app startup - Streamline README.md, DEVELOPMENT.md, DEPLOYMENT.md to remove duplication - Update DEPLOYMENT.md with SP/app principal permission grant instructions - Regenerate yarn.lock to remove internal npm proxy URLs - Fix TestViewService unit tests for module-level _tmp_schema_ready flag
…abs/dqx into feature/app-refactor
- Add public reset_tmp_schema_ready() to view_service to avoid protected-access and import-outside-toplevel pylint violations - Downgrade orval from 8.0.0 to 7.21.0 to fix CI build failure where -i and -c flags conflict in orval 8.0.0
mwojtyczka
reviewed
Apr 29, 2026
mwojtyczka
reviewed
Apr 29, 2026
mwojtyczka
reviewed
Apr 29, 2026
mwojtyczka
reviewed
Apr 29, 2026
mwojtyczka
reviewed
Apr 29, 2026
mwojtyczka
requested changes
Apr 29, 2026
mwojtyczka
reviewed
Apr 29, 2026
mwojtyczka
reviewed
Apr 29, 2026
mwojtyczka
reviewed
Apr 29, 2026
mwojtyczka
reviewed
Apr 29, 2026
…mprove robustness - Fix app permissions in databricks.yml: use account users group for org-wide CAN_USE access; add comments explaining CREATE_TABLE grant and user_api_scopes baseline vs all-apis requirement - Add run_id validation in task runner to prevent SQL identifier injection - Make migrations idempotent: ADD COLUMN IF NOT EXISTS, split multi-statement DDL, catch already-applied errors (COLUMN_ALREADY_EXISTS, liquid clustering) - Use escape_sql_string for migration history INSERT consistency - Fix cache MISS sentinel so None return values are cached correctly, preventing repeated upstream calls for missing-data lookups - Fix SPA static file fallback: use asset extension allowlist instead of dot-in-segment heuristic to avoid false 404s on routes like /rules/v1.2 - Fix deprecated regex to pattern in quarantine export Query param - Add post_deploy_grants.sh script and update DEPLOYMENT.md - Update unit tests for cache sentinel and multi-statement migration counts
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Linked issues
This pull request introduces major improvements to the DQX App's documentation and deployment configuration, focusing on clarifying the architecture, authentication model, and deployment steps, as well as enhancing the Databricks Asset Bundle (
databricks.yml) to provision all required resources automatically. The changes also update development dependencies and provide a comprehensive product overview in a newCLAUDE.mdfile.Key changes include:
1. Documentation and Product Context
CLAUDE.mdwith a detailed product overview, architecture diagram, personas, user journeys, and internal storage design for the DQX App. This helps new contributors and users understand the app's purpose, scope, and design decisions.README.mdto clarify the authentication model (OBO vs. SP), async job pattern for Spark operations, deployment steps, troubleshooting, and removed outdated configuration steps. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]2. Deployment Automation and Resource Provisioning
databricks.ymlto:3. Dependency Updates
databricks-connectwithdatabricks-sql-connector[pyarrow]inpyproject.toml, reflecting the new architecture where Spark operations are offloaded to a Databricks Job rather than running in-process.4. Development and Troubleshooting
These changes make the app easier to deploy, maintain, and understand, and set a strong foundation for future development.
References:
[1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]
Resolves #..
Tests