Skip to content

Feature/solutions accelerators and demos#1100

Merged
mwojtyczka merged 8 commits intodatabrickslabs:mainfrom
fedeflowers:feature/solutions_accelerators_and_demos
Apr 23, 2026
Merged

Feature/solutions accelerators and demos#1100
mwojtyczka merged 8 commits intodatabrickslabs:mainfrom
fedeflowers:feature/solutions_accelerators_and_demos

Conversation

@fedeflowers
Copy link
Copy Markdown
Contributor

Changes

  • New Industry Accelerators: Added comprehensive Banking and Fashion industry demos to the demos/dqx_demo_industry/ directory.
    • dqx_banking_demo.py: Focused on fraud detection and transaction monitoring.
    • dqx_fashion_demo.py: Rebuilt with industry best practices, including custom check functions and 11 industry-specific quality rules.
  • Improved Repo Organization: Moved the Manufacturing demo (dqx_manufacturing_demo.py) into the demos/dqx_demo_industry/ subdirectory.
  • Enhanced Documentation: Updated docs/dqx/docs/demos.mdx with a new "Industry Accelerators" section

Linked issues

Resolves #454

Tests

  • manually tested
  • added unit tests
  • added integration tests
  • added end-to-end tests
  • added performance tests

@fedeflowers fedeflowers requested a review from a team as a code owner March 30, 2026 18:07
@fedeflowers fedeflowers requested review from grusin-db and removed request for a team March 30, 2026 18:07
@mwojtyczka mwojtyczka added the under-review This PR is currently being reviewed by one of DQX maintainers. label Mar 31, 2026
Copy link
Copy Markdown
Contributor

@mwojtyczka mwojtyczka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Industry Accelerator Demos

Good showcase of DQX capabilities across banking, fashion, and manufacturing verticals. The demos are well-structured with clear documentation. A few items to address.

Comment thread demos/dqx_demo_industry/dqx_banking_demo.py
Comment thread demos/dqx_demo_industry/dqx_banking_demo.py
Comment thread demos/dqx_demo_industry/dqx_fashion_demo.py
Comment thread demos/dqx_demo_industry/dqx_fashion_demo.py Outdated
Copy link
Copy Markdown
Contributor Author

@fedeflowers fedeflowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Updated Conftest: Configured end-to-end (E2E) tests to execute from the fork repository.
  • Improved Banking Demo: Fixed the is_suspicious_amount_pattern hardcoded threshold.
  • Ensured Consistency: Conformed formatting to align with previous demos.

@fedeflowers fedeflowers requested a review from mwojtyczka April 2, 2026 12:51
Copy link
Copy Markdown
Collaborator

@ghanse ghanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments.

Comment thread demos/dqx_demo_industry/dqx_banking_demo.py Outdated
Comment thread demos/dqx_demo_industry/dqx_banking_demo.py
Comment thread demos/dqx_demo_industry/dqx_banking_demo.py
Comment thread demos/dqx_demo_industry/dqx_fashion_demo.py
Comment thread demos/dqx_demo_industry/dqx_fashion_demo.py Outdated
Comment thread demos/dqx_demo_industry/dqx_fashion_demo.py
Comment thread demos/dqx_demo_industry/dqx_banking_demo.py
Comment thread demos/dqx_demo_industry/dqx_fashion_demo.py
@fedeflowers fedeflowers requested a review from ghanse April 6, 2026 22:10
@github-actions
Copy link
Copy Markdown
Contributor

All commits in PR should be signed ('git commit -S ...'). See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@mwojtyczka
Copy link
Copy Markdown
Contributor

@fedeflowers thank you for the PR. We require all commits to be signed. Please follow the instructions: https://databrickslabs.github.io/dqx/docs/dev/contributing/#first-contribution

Copy link
Copy Markdown
Contributor

@mwojtyczka mwojtyczka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I run all demos manually and from local

@mwojtyczka mwojtyczka force-pushed the feature/solutions_accelerators_and_demos branch from 6567726 to 718dc9c Compare April 15, 2026 12:04
@mwojtyczka
Copy link
Copy Markdown
Contributor

@fedeflowers thank you for the PR. We require all commits to be signed. Please follow the instructions: https://databrickslabs.github.io/dqx/docs/dev/contributing/#first-contribution

I repushed

@mwojtyczka mwojtyczka added the Approved to Merge When PR is reviewed and approved. To be merged once all tests pass label Apr 15, 2026
@mwojtyczka mwojtyczka removed the under-review This PR is currently being reviewed by one of DQX maintainers. label Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved to Merge When PR is reviewed and approved. To be merged once all tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Solutions accelerators and demos for different industries

3 participants