Fork test: PR #1203 - feat: implement semantic rule validation for DQ rules (#1169)#1288
Closed
mwojtyczka wants to merge 15 commits into
Closed
Fork test: PR #1203 - feat: implement semantic rule validation for DQ rules (#1169)#1288mwojtyczka wants to merge 15 commits into
mwojtyczka wants to merge 15 commits into
Conversation
- Fix IndentationError on load_checks/save_checks so the package compiles - Use full-notation import; remove leftover marker comments and trailing whitespace in docstrings; drop backticks in docstrings per AGENTS.md - Rename module to checks_semantic_validator and classes to ChecksSemanticValidator / ChecksSemanticValidationMode - Fix unhashable-list crash in rule key by serializing arguments with json - Harden helpers against malformed checks; handle mode=None in apply() - Expose semantic_validation_mode on the public DQEngine.validate_checks - Add negative integration tests for validate_checks, load_checks and save_checks (duplicate and conflicting rules) Co-authored-by: Isaac
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1288 +/- ##
==========================================
+ Coverage 92.50% 92.72% +0.21%
==========================================
Files 102 103 +1
Lines 10102 10378 +276
==========================================
+ Hits 9345 9623 +278
+ Misses 757 755 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
✅ 784/784 passed, 1 flaky, 49 skipped, 6h13m33s total Flaky tests:
Running from acceptance #5032 |
Contributor
|
✅ 194/194 passed, 2 skipped, 7h35m30s total Running from anomaly #1146 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated sync from fork PR for CI testing.
Original PR: #1203
All tests, including unit and integration tests run on this PR (they are skipped for fork PRs).