Skip to content

Fork test: PR #1203 - feat: implement semantic rule validation for DQ rules (#1169)#1288

Closed
mwojtyczka wants to merge 15 commits into
mainfrom
fork-test/pr-1203
Closed

Fork test: PR #1203 - feat: implement semantic rule validation for DQ rules (#1169)#1288
mwojtyczka wants to merge 15 commits into
mainfrom
fork-test/pr-1203

Conversation

@mwojtyczka

Copy link
Copy Markdown
Contributor

Automated sync from fork PR for CI testing.

Original PR: #1203

All tests, including unit and integration tests run on this PR (they are skipped for fork PRs).

Vsatyam013 and others added 10 commits May 27, 2026 22:13
- Fix IndentationError on load_checks/save_checks so the package compiles
- Use full-notation import; remove leftover marker comments and trailing
  whitespace in docstrings; drop backticks in docstrings per AGENTS.md
- Rename module to checks_semantic_validator and classes to
  ChecksSemanticValidator / ChecksSemanticValidationMode
- Fix unhashable-list crash in rule key by serializing arguments with json
- Harden helpers against malformed checks; handle mode=None in apply()
- Expose semantic_validation_mode on the public DQEngine.validate_checks
- Add negative integration tests for validate_checks, load_checks and
  save_checks (duplicate and conflicting rules)

Co-authored-by: Isaac
@mwojtyczka mwojtyczka requested a review from a team as a code owner June 30, 2026 11:53
@mwojtyczka mwojtyczka added do-not-merge The PR is blocked, e.g. being worked on and not ready. Not using draft to be able to test changes. fork-test labels Jun 30, 2026
@mwojtyczka mwojtyczka requested review from nehamilak-db and removed request for a team June 30, 2026 11:53
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.31902% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.72%. Comparing base (d1d2a9b) to head (e9b04b2).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...c/databricks/labs/dqx/checks_semantic_validator.py 96.05% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1288      +/-   ##
==========================================
+ Coverage   92.50%   92.72%   +0.21%     
==========================================
  Files         102      103       +1     
  Lines       10102    10378     +276     
==========================================
+ Hits         9345     9623     +278     
+ Misses        757      755       -2     
Flag Coverage Δ
anomaly 53.80% <26.38%> (-0.45%) ⬇️
anomaly-serverless 53.81% <26.38%> (-0.45%) ⬇️
integration 50.99% <66.25%> (+2.80%) ⬆️
integration-serverless 50.92% <66.25%> (+0.30%) ⬆️
unit 58.48% <96.31%> (+1.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

✅ 784/784 passed, 1 flaky, 49 skipped, 6h13m33s total

Flaky tests:

  • 🤪 test_profiler_workflow_filter_out_all_data (2m18.73s)

Running from acceptance #5032

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

✅ 194/194 passed, 2 skipped, 7h35m30s total

Running from anomaly #1146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge The PR is blocked, e.g. being worked on and not ready. Not using draft to be able to test changes. fork-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants