Prompt user to reconfigure reconcile on UC connections migration#2399
Open
Prompt user to reconfigure reconcile on UC connections migration#2399
Conversation
m-abulazm
added
feat/recon
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2399 +/- ##
==========================================
+ Coverage 65.78% 65.84% +0.05%
==========================================
Files 98 98
Lines 9237 9258 +21
Branches 992 995 +3
==========================================
+ Hits 6077 6096 +19
- Misses 2984 2985 +1
- Partials 176 177 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ 148/148 passed, 5 skipped, 22m52s total Running from acceptance #4261 |
m-abulazm
force-pushed
the
feat/recon/upgrade-config-prompt
branch
from
c27b0da to
e38d515
Compare
m-abulazm
force-pushed
the
feat/recon/upgrade-config-prompt
branch
from
e38d515 to
81c5b1f
Compare
7 tasks
m-abulazm
force-pushed
the
feat/recon/upgrade-config-prompt
branch
from
81c5b1f to
2ded0ac
Compare
asnare
reviewed
May 1, 2026
Contributor
asnare
left a comment
asnare
left a comment
There was a problem hiding this comment.
I've had a quick skim, but my focus right now is on getting main all green. One thing that caught my eye on this is why the addition of those _ arguments on the tests?
|
|
||
| @patch("webbrowser.open") | ||
| def test_configure_reconcile_no_existing_installation(ws: WorkspaceClient) -> None: | ||
| def test_configure_reconcile_no_existing_installation(_, ws: WorkspaceClient) -> None: |
Contributor
Author
There was a problem hiding this comment.
we patch webbrowser.open although we dont assert against it. The test method signature did not reflect that
|
|
||
| @patch("webbrowser.open") | ||
| def test_configure_reconcile_databricks_no_existing_installation(ws: WorkspaceClient) -> None: | ||
| def test_configure_reconcile_databricks_no_existing_installation(_, ws: WorkspaceClient) -> None: |
m-abulazm
force-pushed
the
feat/recon/upgrade-config-prompt
branch
from
10f317f to
ab52979
Compare
v1_migrate) and re-runs the reconcile configuration prompts so the user can supply the Unity Catalog connection name.
m-abulazm
force-pushed
the
feat/recon/upgrade-config-prompt
branch
from
ab52979 to
1de2023
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
What does this PR do?
After migrating recon to Unity Catalog connections, old config with secret scopes are broken and need the config to be recreated with the connection. that scenario is detected during the install and the user is prompted if they want to configure reconcile and create the connection
Relevant implementation details
A deliberate choice of letting the user create the connection is implemented instead of silently creating the connection. As different sources need different create options and instead of owning that complexity, it is deferred to the product itself in databricks and user can follow the official docs
Caveats/things to watch out for when reviewing:
We don't check if the connection exists after the user enters it and that can be implemented in a subsequent PR if the resulting UX improvement is valid
Functionality
databricks labs install/upgrade lakebridgeTests