feat(lakebridge): generate analyzer JSON by default#2400
Open
simone-dbx-labs wants to merge 4 commits into
Open
feat(lakebridge): generate analyzer JSON by default#2400simone-dbx-labs wants to merge 4 commits into
simone-dbx-labs wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2400 +/- ##
=======================================
Coverage 64.58% 64.58%
=======================================
Files 103 103
Lines 9408 9408
Branches 992 992
=======================================
Hits 6076 6076
Misses 3156 3156
Partials 176 176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ 148/148 passed, 5 skipped, 41m44s total Running from acceptance #4339 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
What does this PR do?
databricks labs lakebridge analyzenow generates the analyzer JSON file by default, alongside the Excel report. That matches how migration estimator and UI flows consume analyzer output, without requiring--generate-json true.Users who only want Excel can opt out with
--generate-json false.Relevant implementation details
generate_jsondefaults toTrueincli.analyze,LakebridgeAnalyzer.run_analyzer, andAnalyzerRunner.run, so programmatic callers get the same behavior as the CLI.databricks-bb-analyzerstill receive a-jJSON path whenever JSON generation is enabled (unchanged wiring; only the default flipped).docs/lakebridge/docs/assessment/analyzer/index.mdx): describe default-on JSON, how to skip JSON, and updated help-style flag text..jsonpresence andgenerate_json=Falseskips JSON; mock-basedLakebridgeAnalyzertests cover default vs explicit opt-out (including prompt flows).Caveats/things to watch out for when reviewing:
--generate-jsonwill now produce an extra.jsonfile next to the report path (same stem,.jsonextension). Downstream disk usage and CI fixtures that assumed “Excel only” may need to ignore or clean.json, or pass--generate-json false.--helpblock in the Analyzer guide): text was updated; if the team keeps screenshots in sync with CLI output, verify whether that GIF/screenshot needs a refresh (optional follow-up).Linked issues
Related to databrickslabs/bladerunner#844 (analyzer JSON default; implemented in Lakebridge CLI).
Functionality
databricks labs lakebridge analyzeTests