Skip to content

Lockfile linting and dependency updates#2434

Merged
asnare merged 13 commits into
mainfrom
dependency-handling
May 13, 2026
Merged

Lockfile linting and dependency updates#2434
asnare merged 13 commits into
mainfrom
dependency-handling

Conversation

@asnare

@asnare asnare commented May 12, 2026

Copy link
Copy Markdown
Contributor

Changes

This primary purpose of this PR is:

  • Fixing some changes to uv.lock that were inadvertently introduced in Add SQL Server Profiler #2151.
  • Updating our CI to detect issues in PRs relating to the lock-files.

The intention within this repo is:

  • The lock-files should only update under 2 circumstances:

    • A refresh-only update of the lock-files.
    • A dependency in pyproject.toml has been changed.
  • Outside of this, uv.lock and .build-constraints.txt should not be changing.

  • When they change, it should be via make lock-dependencies which ensures uv.lock refers to PyPI properly. (Manual review is unlikely to spot the error if a dev proxy is in there, so this PR automates the check.)

Further to these linting-releated changes:

Finally, to verify the linting this PR updates some dependencies:

  • Versions are locked against the highest version.
  • Outstanding dependabot updates are included.

Relevant implementation details

The linting script has been written so that it can be run locally by developers, it doesn't require the GHA environment to be in place.

Linked Issues

Resolves: #2373

Subsumes:

Tests

  • manually tested
  • new CI check

@asnare asnare self-assigned this May 12, 2026
@asnare asnare added github_actions Pull requests that update GitHub Actions code internal technical pr's not end user facing labels May 12, 2026
@codecov

codecov Bot commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.76%. Comparing base (a8ff8a2) to head (c8c6d32).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2434   +/-   ##
=======================================
  Coverage   64.76%   64.76%           
=======================================
  Files         104      104           
  Lines        9457     9457           
  Branches      994      994           
=======================================
  Hits         6125     6125           
  Misses       3156     3156           
  Partials      176      176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown

✅ 154/154 passed, 4 flaky, 3 skipped, 1h47m52s total

Flaky tests:

  • 🤪 test_recon_sql_server_job_succeeds (20m34.258s)
  • 🤪 test_recon_databricks_job_succeeds (20m42.632s)
  • 🤪 test_recon_redshift_job_succeeds (20m34.569s)
  • 🤪 test_recon_oracle_job_succeeds (20m38.01s)

Running from acceptance #4376

@asnare
asnare marked this pull request as ready for review May 12, 2026 16:11
@asnare
asnare requested a review from a team as a code owner May 12, 2026 16:11
@asnare asnare added the bug Something isn't working label May 12, 2026
@asnare asnare changed the title Dependency handling Lockfile linting and dependency updates May 12, 2026

@gueniai gueniai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simone-dbx-labs simone-dbx-labs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgomez04 dgomez04 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting. Looks good to me!

@gueniai
gueniai added this pull request to the merge queue May 12, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks May 12, 2026
When running inside the merge queue the merge base needs to be detected and handled in a different manner.
@asnare
asnare enabled auto-merge May 13, 2026 08:50
@asnare
asnare added this pull request to the merge queue May 13, 2026
Merged via the queue into main with commit e50dae5 May 13, 2026
6 checks passed
@asnare
asnare deleted the dependency-handling branch May 13, 2026 09:47
ameersalman33 pushed a commit to ameersalman33/lakebridge that referenced this pull request May 19, 2026
## Changes

This PR adjusts the some of the lockfile handling:

- We now use `https://pypi.org/simple` (no trailing-slash) instead of
`https://pypi.org/simple/` as the PyPI registry URL: this avoids
spurious updates from dependabot.
- Detection of lockfile drift is more robust: sometimes uv uses
hatchling to examine the project, and hatchling needs more than the
skeleton `pyproject.toml` that was being checked.

Some trivial dependency updates are included in this PR.

### Linked issues

Follows: databrickslabs#2434

Subsumes:
 - databrickslabs#2436
 - databrickslabs#2439
 - databrickslabs#2440

### Functionality

- updated uv linting

### Tests

- manually tested
- `lint-uv` job (workflow: `push.yml`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working github_actions Pull requests that update GitHub Actions code internal technical pr's not end user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Analyzer crash on macOS reading Windows-1252-encoded Informatica XML

4 participants