Lockfile linting and dependency updates#2434
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2434 +/- ##
=======================================
Coverage 64.76% 64.76%
=======================================
Files 104 104
Lines 9457 9457
Branches 994 994
=======================================
Hits 6125 6125
Misses 3156 3156
Partials 176 176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ 154/154 passed, 4 flaky, 3 skipped, 1h47m52s total Flaky tests:
Running from acceptance #4376 |
dgomez04
approved these changes
May 12, 2026
dgomez04
left a comment
Contributor
There was a problem hiding this comment.
Very interesting. Looks good to me!
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
May 12, 2026
When running inside the merge queue the merge base needs to be detected and handled in a different manner.
asnare
enabled auto-merge
May 13, 2026 08:50
ameersalman33
pushed a commit
to ameersalman33/lakebridge
that referenced
this pull request
May 19, 2026
## Changes This PR adjusts the some of the lockfile handling: - We now use `https://pypi.org/simple` (no trailing-slash) instead of `https://pypi.org/simple/` as the PyPI registry URL: this avoids spurious updates from dependabot. - Detection of lockfile drift is more robust: sometimes uv uses hatchling to examine the project, and hatchling needs more than the skeleton `pyproject.toml` that was being checked. Some trivial dependency updates are included in this PR. ### Linked issues Follows: databrickslabs#2434 Subsumes: - databrickslabs#2436 - databrickslabs#2439 - databrickslabs#2440 ### Functionality - updated uv linting ### Tests - manually tested - `lint-uv` job (workflow: `push.yml`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This primary purpose of this PR is:
uv.lockthat were inadvertently introduced in Add SQL Server Profiler #2151.The intention within this repo is:
The lock-files should only update under 2 circumstances:
pyproject.tomlhas been changed.Outside of this,
uv.lockand.build-constraints.txtshould not be changing.When they change, it should be via
make lock-dependencieswhich ensuresuv.lockrefers to PyPI properly. (Manual review is unlikely to spot the error if a dev proxy is in there, so this PR automates the check.)Further to these linting-releated changes:
make lock-dependenciesnow locks to the latest versions of dependencies instead of keeping the existing versions if they're still within their allowed version range.databricks-bb-analyzer==0.3.1is blocked: the analyzer binary in this release doesn't work properly. (Issue [BUG]: Analyzer crash on macOS reading Windows-1252-encoded Informatica XML #2373.)Finally, to verify the linting this PR updates some dependencies:
Relevant implementation details
The linting script has been written so that it can be run locally by developers, it doesn't require the GHA environment to be in place.
Linked Issues
Resolves: #2373
Subsumes:
Tests