Add cross-profiler timestamp fidelity regression tests#2553
Open
nnigam19 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2553 +/- ##
==========================================
+ Coverage 69.20% 69.63% +0.43%
==========================================
Files 105 105
Lines 9498 9498
Branches 1052 1052
==========================================
+ Hits 6573 6614 +41
+ Misses 2728 2675 -53
- Partials 197 209 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
✅ 169/169 passed, 7 flaky, 2 skipped, 1h33m7s total Flaky tests:
Running from acceptance #5010 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds unit regression tests verifying that every profiler preserves timestamp
wall-clock fidelity when writing its extract into DuckDB. No production code
changes.
Both shared ingestion paths are covered:
DatabaseManager.fetch→FetchResult.to_df()→PipelineClass._save_to_db,driven through the public
PipelineClass.execute()with a fake executor so thereal ingestion wiring is exercised end to end.
save_to_duckdb().What the tests assert
TIMESTAMP, with itswall-clock reading intact.
TIMESTAMP WITH TIME ZONE).session time zone (
America/Loles,Asia/Kolkata,Pacific/Kiritimati).25 parametrized cases across all seven profilers.
Testing
pytest: 25 passed