Compress profiler extracts with zstd for easier sharing#2568
Open
dgomez04 wants to merge 8 commits into
Open
Conversation
After a successful profile run, keep the DuckDB .db for local inspection and write a sibling .db.zst (zstd level 3). Log explicit share instructions so customers send the compressed artifact to Databricks.
|
✅ 174/174 passed, 9 flaky, 2 skipped, 1h14m8s total Flaky tests:
Running from acceptance #5058 |
`uv add` rewrote registry/CDN URLs to the Databricks proxy; restore the public pypi.org / files.pythonhosted.org form expected in this repo.
Restore the lockfile from main and only declare zstandard on databricks-labs-lakebridge, avoiding proxy URL rewrites from `uv add`.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2568 +/- ##
==========================================
+ Coverage 69.50% 69.53% +0.02%
==========================================
Files 107 108 +1
Lines 9626 9650 +24
Branches 1065 1067 +2
==========================================
+ Hits 6691 6710 +19
- Misses 2734 2738 +4
- Partials 201 202 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Compress immediately after the DuckDB write and log both paths in the same "extract written" message. Warn only if compression fails.
Move the round-trip check onto save_to_duckdb output, assert .zst in profiler integration runs, and keep only the non-fatal compress failure test.
zstd for easier sharing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request integrates inline Zstandard (
zstd) compression into the extract finalization step. Upon a succesful profiler run, we now generate a compressed sibling.db.zst..db.zstwhile retaining uncompressed.dbfor local debugging and UI compatibility.zstandardto the direct dependencies.Decision