Skip to content

Parametrize acceptance action with pytest parallel worker count #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexott merged 7 commits into from
Apr 28, 2026
Merged

Parametrize acceptance action with pytest parallel worker count #730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
840db12
parametrize the action with numbe rof parallel pytest workers
mwojtyczka Apr 21, 2026
0ec0b39
updated depreciated sdk methods
mwojtyczka Apr 21, 2026
983334d
Validate n input and handle empty PYTEST_N
mwojtyczka Apr 21, 2026
18f26d3
handle invalid n param
mwojtyczka Apr 21, 2026
2928daf
Drop redundant n validation in Go
mwojtyczka Apr 21, 2026
a2146e9
Set INPUT_N in TestXxx integration test
mwojtyczka Apr 21, 2026
5584c09
added comment
mwojtyczka Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions acceptance/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ inputs:
codegen_path:
description: 'Relative path to the .codegen.json file to use for configuring the acceptance tests'
required: false # by default the first .codegen.json found in the project is used
n:
description: 'Number of parallel pytest workers (pytest-xdist -n).'
required: false
default: '10'
Comment thread
alexott marked this conversation as resolved.
outputs:
sample:
description: 'Sample output'
Expand Down
2 changes: 1 addition & 1 deletion acceptance/ecosystem/pytest_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def pytest_runtest_logreport(self, report: pytest.TestReport):

if __name__ == '__main__':
sys.exit(pytest.main([
'-n', '10',
'-n', (os.environ.get('PYTEST_N') or '').strip() or '10',
"--log-disable", "urllib3.connectionpool",
"--log-format", "%(asctime)s %(levelname)s [%(name)s] %(message)s",
"--log-date-format", "%H:%M",
Expand Down
3 changes: 3 additions & 0 deletions acceptance/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ func (a *acceptance) trigger(ctx context.Context) (*notify.Notification, error)
// set codegen path file used for configuring the acceptance tests
codegenPath := a.Action.GetInput("codegen_path")
ctx = env.Set(ctx, "codegen_path", codegenPath)
if n := a.Action.GetInput("n"); n != "" {
ctx = env.Set(ctx, "PYTEST_N", n)
}
redact := loaded.Redaction()
report, err := a.runWithTimeout(ctx, redact, directory)
if err != nil {
Expand Down
1 change: 1 addition & 0 deletions acceptance/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ func TestXxx(t *testing.T) {
t.Skip()
ctx := context.Background()
ctx = env.Set(ctx, "INPUT_DIRECTORY", "../go-libs")
ctx = env.Set(ctx, "INPUT_N", "4") // verify PYTEST_N=4 in pytest output
err := run(ctx)
assert.NoError(t, err)
}
2 changes: 1 addition & 1 deletion acceptance/testenv/githubOidc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func (cpf *credentialsProviderFunc) SetHeaders(r *http.Request) error {

// Configure implements credentials provider for Databricks SDK
func (c *ghOidcCreds) Configure(ctx context.Context, cfg *config.Config) (credentials.CredentialsProvider, error) {
ts, err := c.oidcTokenSource(ctx, cfg.Environment().AzureApplicationID)
ts, err := c.oidcTokenSource(ctx, environment.GetEnvironmentForHostname(cfg.CanonicalHostName()).AzureApplicationID)
if err != nil {
return nil, fmt.Errorf("oidc: %w", err)
}
Expand Down
7 changes: 4 additions & 3 deletions acceptance/testenv/loaded.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ func (l *loadedEnv) Cloud() environment.Cloud {
if err != nil {
return environment.CloudAWS
}
return cfg.Environment().Cloud
return environment.GetEnvironmentForHostname(cfg.CanonicalHostName()).Cloud
}

func (l *loadedEnv) Start(ctx context.Context) (context.Context, func(), error) {
Expand All @@ -80,7 +80,8 @@ func (l *loadedEnv) Start(ctx context.Context) (context.Context, func(), error)
return nil, nil, fmt.Errorf("config: %w", err)
}
srv := l.metadataServer(cfg)
ctx = env.Set(ctx, "CLOUD_ENV", strings.ToLower(string(cfg.Environment().Cloud)))
cloud := environment.GetEnvironmentForHostname(cfg.CanonicalHostName()).Cloud
ctx = env.Set(ctx, "CLOUD_ENV", strings.ToLower(string(cloud)))
ctx = env.Set(ctx, "DATABRICKS_METADATA_SERVICE_URL", fmt.Sprintf("%s/%s", srv.URL, l.mpath))
ctx = env.Set(ctx, "DATABRICKS_AUTH_TYPE", "metadata-service")
isAuth := map[string]bool{}
Expand All @@ -104,7 +105,7 @@ func (l *loadedEnv) Start(ctx context.Context) (context.Context, func(), error)
}

func (l *loadedEnv) metadataServer(seed *config.Config) *httptest.Server {
accountHost := seed.Environment().DeploymentURL("accounts")
accountHost := environment.GetEnvironmentForHostname(seed.CanonicalHostName()).DeploymentURL("accounts")
configurations := map[string]*config.Config{
seed.CanonicalHostName(): seed,
accountHost: {
Expand Down