feat(insights): harden deterministic investigations

Author: izadoesdev

.env.example

@@ -9,6 +9,9 @@ BULLMQ_REDIS_URL="redis://localhost:6379"
 INSIGHTS_PORT="4002"
 INSIGHTS_BULLMQ_REDIS_URL=""
 INSIGHTS_DISPATCH_INTERVAL_MS="300000"
+INSIGHTS_SCHEDULED_DISPATCH_ENABLED="false"
+# Comma-separated organization IDs for canaries; use * only after rollout.
+INSIGHTS_SCHEDULED_ORGANIZATION_IDS=""
 INSIGHTS_MAINTENANCE_INTERVAL_MS="300000"
 INSIGHTS_STALE_ITEM_MS="900000"
 INSIGHTS_WORKER_CONCURRENCY="2"

apps/dashboard/app/(main)/insights/hooks/use-insights-local-state.ts

@@ -93,12 +93,9 @@ export function useInsightsLocalState(
 
 	const setFeedbackAction = useCallback(
 		(insightId: string, vote: "up" | "down" | null) => {
-			if (!organizationId) {
-				return;
-			}
 			setVoteMutation.mutate({ insightId, vote });
 		},
-		[organizationId, setVoteMutation]
+		[setVoteMutation]
 	);
 
 	const feedbackById = votesQuery.data?.votes ?? {};

apps/insights/src/delivery.test.ts

@@ -91,6 +91,41 @@ describe("Slack finding blocks", () => {
 		);
 	});
 
+	it("honors Retry-After values longer than five seconds", async () => {
+		const responses = [
+			new Response("rate limited", {
+				headers: { "Retry-After": "120" },
+				status: 429,
+			}),
+			Response.json({ ok: true, ts: "123.456" }),
+		];
+		const delays: number[] = [];
+		const fetcher = (async () => {
+			const response = responses.shift();
+			if (!response) {
+				throw new Error("Unexpected Slack request");
+			}
+			return response;
+		}) as typeof fetch;
+
+		await postToSlack(
+			"token",
+			"channel-test",
+			[{ type: "divider" }],
+			"Finding",
+			"effect-test",
+			{
+				fetcher,
+				random: () => 0,
+				sleep: async (milliseconds) => {
+					delays.push(milliseconds);
+				},
+			}
+		);
+
+		expect(delays).toEqual([120_000]);
+	});
+
 	it("uses the durable effect ID as Slack's client message ID", () => {
 		expect(
 			buildSlackPostPayload(

apps/insights/src/delivery.ts

@@ -15,7 +15,6 @@ const SLACK_POST_URL = "https://slack.com/api/chat.postMessage";
 const SLACK_POST_TIMEOUT_MS = 10_000;
 const SLACK_RATE_LIMIT_ATTEMPTS = 3;
 const SLACK_RATE_LIMIT_FALLBACK_MS = 1000;
-const SLACK_RATE_LIMIT_MAX_WAIT_MS = 5000;
 const MAX_DIGEST_INSIGHTS = 3;
 const MAX_ONGOING_LINES = 5;
 const SLACK_HEADER_MAX = 150;
@@ -436,10 +435,7 @@ function rateLimitDelay(response: Response, random: () => number): number {
 		Number.isFinite(seconds) && seconds > 0
 			? seconds * 1000
 			: SLACK_RATE_LIMIT_FALLBACK_MS;
-	return (
-		Math.min(requested, SLACK_RATE_LIMIT_MAX_WAIT_MS) +
-		Math.floor(random() * 250)
-	);
+	return requested + Math.floor(random() * 250);
 }
 
 export async function postToSlack(