fix(release): address review feedback

Author: izadoesdev

apps/api/src/integration/cache-auth-bypass.test.ts

@@ -1,6 +1,6 @@
 import "@databuddy/test/env";
 
-import { targetGroups } from "@databuddy/db/schema";
+import { flags, targetGroups } from "@databuddy/db/schema";
 import { appRouter, type Context } from "@databuddy/rpc";
 import {
 	addToOrganization,
@@ -50,6 +50,22 @@ async function seedTargetGroup(websiteId: string, createdBy: string) {
 		});
 }
 
+async function seedFlag(websiteId: string, createdBy: string) {
+	await db()
+		.insert(flags)
+		.values({
+			id: randomUUIDv7(),
+			websiteId,
+			key: "secret-rollout",
+			name: "Secret Rollout",
+			description: "Internal rollout definition",
+			defaultValue: true,
+			status: "active",
+			rules: [{ field: "country", operator: "equals", value: "US" }],
+			createdBy,
+		});
+}
+
 const annotationsParams = (websiteId: string) =>
 	({
 		websiteId,
@@ -145,6 +161,7 @@ describe("cache-bypass auth: target-groups.list", () => {
 describe("cache-bypass auth: flags.list", () => {
 	iit("anon caller cannot read flags after authed prime", async () => {
 		const { user, org, site } = await setupOwnedSite();
+		await seedFlag(site.id, user.id);
 
 		await call(
 			appRouter.flags.list,
@@ -160,6 +177,7 @@ describe("cache-bypass auth: flags.list", () => {
 	iit("cross-org user is rejected after authed prime", async () => {
 		const a = await setupOwnedSite();
 		const b = await setupOwnedSite();
+		await seedFlag(a.site.id, a.user.id);
 
 		await call(
 			appRouter.flags.list,
@@ -176,13 +194,39 @@ describe("cache-bypass auth: flags.list", () => {
 	});
 
 	iit("demo caller cannot read public-site flag definitions", async () => {
-		const { site } = await setupOwnedSite({ isPublic: true });
+		const { user, org, site } = await setupOwnedSite({ isPublic: true });
+		await seedFlag(site.id, user.id);
+
+		const authed = await call(
+			appRouter.flags.list,
+			userContext(user, org.id)
+		)({ websiteId: site.id });
+		expect(authed).toHaveLength(1);
 
 		await expectCode(
 			call(appRouter.flags.list, context())({ websiteId: site.id }),
 			"UNAUTHORIZED"
 		);
 	});
+
+	iit("demo caller cannot read public-site flag definitions by key", async () => {
+		const { user, org, site } = await setupOwnedSite({ isPublic: true });
+		await seedFlag(site.id, user.id);
+
+		const authed = await call(
+			appRouter.flags.getByKey,
+			userContext(user, org.id)
+		)({ websiteId: site.id, key: "secret-rollout" });
+		expect(authed).toMatchObject({ key: "secret-rollout" });
+
+		await expectCode(
+			call(appRouter.flags.getByKey, context())({
+				websiteId: site.id,
+				key: "secret-rollout",
+			}),
+			"UNAUTHORIZED"
+		);
+	});
 });
 
 describe("cache-bypass auth: annotations.list", () => {

apps/dashboard/app/(main)/websites/[id]/goals/_components/goal-item.tsx

@@ -26,12 +26,12 @@ interface GoalItemProps {
 function GoalProgress({ rate }: { rate: number }) {
 	const clampedRate = Math.max(0, Math.min(100, rate));
 	return (
-		<span className="block h-5 w-32 overflow-hidden rounded bg-muted lg:w-44">
+		<div className="h-5 w-32 overflow-hidden rounded bg-muted lg:w-44">
 			<div
 				className="h-full rounded bg-chart-1 transition-[width]"
 				style={{ width: `${clampedRate}%` }}
 			/>
-		</span>
+		</div>
 	);
 }
 

apps/dashboard/app/(main)/websites/[id]/settings/general/page.tsx

@@ -108,12 +108,35 @@ export default function GeneralSettingsPage() {
 
 			return { getByIdKey, listKey, previousList, previousWebsite };
 		},
-		onError: (_error, _variables, context) => {
+		onError: (_error, variables, context) => {
 			if (!context) {
 				return;
 			}
-			queryClient.setQueryData(context.getByIdKey, context.previousWebsite);
-			queryClient.setQueryData(context.listKey, context.previousList);
+			const previousIsPublic =
+				context.previousWebsite?.isPublic ??
+				context.previousList?.websites.find(
+					(website) => website.id === variables.id
+				)?.isPublic;
+			queryClient.setQueryData<Website>(context.getByIdKey, (current) => {
+				if (!current) {
+					return context.previousWebsite;
+				}
+				return previousIsPublic === undefined
+					? current
+					: { ...current, isPublic: previousIsPublic };
+			});
+			queryClient.setQueryData<WebsitesListData>(context.listKey, (current) =>
+				current
+					? {
+							...current,
+							websites: current.websites.map((website) =>
+								website.id === variables.id && previousIsPublic !== undefined
+									? { ...website, isPublic: previousIsPublic }
+									: website
+							),
+						}
+					: context.previousList
+			);
 		},
 		onSuccess: (updatedWebsite: Website) => {
 			updateWebsiteCache(queryClient, updatedWebsite);

apps/insights/src/delivery.test.ts

@@ -130,6 +130,76 @@ describe("Slack insight digest markdown", () => {
 		expect(text).not.toContain("Delete funnel");
 	});
 
+	it("filters code-heavy action labels before choosing the next action", () => {
+		const blocks = buildBlocks(
+			"Databuddy",
+			"app.databuddy.cc",
+			[
+				{
+					actions: [{ label: "Run document.execCommand('copy')" }],
+					description: "Clipboard errors increased on onboarding.",
+					id: "clipboard-action",
+					severity: "warning",
+					sentiment: "negative",
+					suggestion: "Review the onboarding clipboard flow.",
+					title: "Clipboard errors increased",
+					type: "persistent_error_hotspot",
+				},
+			],
+			[]
+		);
+
+		const text = sectionText(blocks, 1);
+		expect(text).toContain("Next: Review the onboarding clipboard flow.");
+		expect(text).not.toContain("document.execCommand");
+	});
+
+	it("keeps human-readable error handling suggestions", () => {
+		const blocks = buildBlocks(
+			"Databuddy",
+			"app.databuddy.cc",
+			[
+				{
+					actions: [],
+					description: "Form submissions failed during a network blip.",
+					id: "network-errors",
+					severity: "warning",
+					sentiment: "negative",
+					suggestion:
+						"Wrap the form submission in a try/catch block to handle network errors.",
+					title: "Signup form errors increased",
+					type: "error_spike",
+				},
+			],
+			[]
+		);
+
+		expect(sectionText(blocks, 1)).toContain(
+			"Next: Wrap the form submission in a try/catch block"
+		);
+	});
+
+	it("handles legacy insight rows without type or sentiment fields", () => {
+		const blocks = buildBlocks(
+			"Databuddy",
+			"app.databuddy.cc",
+			[
+				{
+					description: "A historical insight row was missing newer metadata.",
+					id: "legacy-insight",
+					severity: "warning",
+					suggestion: "Review this legacy insight.",
+					title: "Legacy insight still renders",
+				},
+			],
+			[]
+		);
+
+		const text = sectionText(blocks, 1);
+		expect(text).toContain("*Fix · Priority signal*");
+		expect(text).toContain("Next: Review this legacy insight.");
+	});
+
 	it("falls back to the domain when no website name exists", () => {
 		const blocks = buildBlocks(
 			null,

apps/insights/src/delivery.ts

@@ -23,11 +23,11 @@ interface DigestInsight {
 	description: string;
 	id: string;
 	impactSummary?: string | null;
-	sentiment: string;
+	sentiment?: string | null;
 	severity: string;
 	suggestion: string;
 	title: string;
-	type: string;
+	type?: string | null;
 }
 
 interface SlackBlock {
@@ -49,7 +49,7 @@ const IMPLEMENTATION_DETAIL_MARKERS = [
 	"navigator.",
 	"execcommand",
 	"writetext",
-	"try/catch",
+	".catch(",
 ] as const;
 const TRUNCATED_UUID_PATTERN = /\b[0-9a-f]{8}-[0-9a-f]{4}-\.\.\./gi;
 
@@ -232,8 +232,8 @@ function visibleSuggestion(value: string): string | null {
 
 function nextAction(insight: DigestInsight): string {
 	const label = (insight.actions ?? [])
-		.map((action) => action.label.trim())
-		.find(Boolean);
+		.map((action) => visibleSuggestion(action.label))
+		.find((value): value is string => Boolean(value));
 	return (
 		label ??
 		visibleSuggestion(insight.suggestion) ??