test(api): cover trait-history write semantics and cascade delete

Author: izadoesdev

apps/api/src/integration/profile-handlers.test.ts

@@ -5,7 +5,9 @@ import {
 	profiles,
 	profileTraitChanges,
 } from "@databuddy/db/schema";
+import { eq } from "@databuddy/db";
 import { appRouter, type Context } from "@databuddy/rpc";
+import { splitTraits, upsertProfile } from "@databuddy/services/identity";
 import {
 	addToOrganization,
 	cleanup,
@@ -179,3 +181,68 @@ describe("profiles.getHistory", () => {
 		);
 	});
 });
+
+describe("upsertProfile trait history", () => {
+	iit("records baseline on first identify, diff on the next", async () => {
+		const org = await insertOrganization();
+		const website = await insertWebsite({ organizationId: org.id });
+
+		await upsertProfile(website.id, "user_1", splitTraits({ plan: "free" }));
+		await upsertProfile(
+			website.id,
+			"user_1",
+			splitTraits({ plan: "pro" }),
+			"billing"
+		);
+
+		const rows = await db()
+			.select()
+			.from(profileTraitChanges)
+			.where(eq(profileTraitChanges.profileId, "user_1"))
+			.orderBy(profileTraitChanges.createdAt);
+
+		expect(rows).toHaveLength(2);
+		expect(rows[0]?.changes).toEqual({ plan: { old: null, new: "free" } });
+		expect(rows[0]?.source).toBe("identify");
+		expect(rows[1]?.changes).toEqual({ plan: { old: "free", new: "pro" } });
+		expect(rows[1]?.source).toBe("billing");
+		expect(rows[1]?.traits).toEqual({ plan: "pro" });
+	});
+
+	iit("writes no history row when traits are unchanged", async () => {
+		const org = await insertOrganization();
+		const website = await insertWebsite({ organizationId: org.id });
+
+		await upsertProfile(website.id, "user_1", splitTraits({ plan: "pro" }));
+		await upsertProfile(website.id, "user_1", splitTraits({ plan: "pro" }));
+
+		const rows = await db()
+			.select()
+			.from(profileTraitChanges)
+			.where(eq(profileTraitChanges.profileId, "user_1"));
+
+		expect(rows).toHaveLength(1);
+	});
+
+	iit("cascades history deletion when the profile is deleted", async () => {
+		const org = await insertOrganization();
+		const website = await insertWebsite({ organizationId: org.id });
+
+		await upsertProfile(website.id, "user_1", splitTraits({ plan: "pro" }));
+		expect(
+			await db()
+				.select()
+				.from(profileTraitChanges)
+				.where(eq(profileTraitChanges.profileId, "user_1"))
+		).toHaveLength(1);
+
+		await db().delete(profiles).where(eq(profiles.profileId, "user_1"));
+
+		expect(
+			await db()
+				.select()
+				.from(profileTraitChanges)
+				.where(eq(profileTraitChanges.profileId, "user_1"))
+		).toHaveLength(0);
+	});
+});