fix more issue

Signed-off-by: yxxhero <aiopsclub@163.com>

Author: yxxhero

.github/copilot-instructions.md

@@ -28,7 +28,7 @@ Always reference these instructions first and fallback to search or bash command
 - ALWAYS run `make format` and `make lint` before committing changes.
 
 **Plugin Installation:**
-- Install as Helm plugin: `make install` or `make install/helm3` - builds and installs to Helm plugins directory. Takes ~3 seconds.
+- Install as Helm plugin: `make install` or `make install/helm` - builds and installs to Helm plugins directory. Takes ~3 seconds.
 - The plugin installs via `install-binary.sh` script which handles cross-platform binary installation.
 
 ## Validation Scenarios

.github/workflows/ci.yaml

@@ -127,7 +127,7 @@ jobs:
         run: helm version
 
       - name: helm plugin install
-        run: helm plugin install .
+        run: make install/helm
 
       - name: helm create helm-diff
         run: helm create helm-diff

Makefile

@@ -1,7 +1,7 @@
 HELM_HOME ?= $(shell helm env HELM_DATA_HOME)
 VERSION := $(shell sed -n -e 's/version:[ "]*\([^"]*\).*/\1/p' plugin.yaml)
 
-HELM_3_PLUGINS := $(shell helm env HELM_PLUGINS)
+HELM_PLUGINS := $(shell helm env HELM_PLUGINS)
 
 PKG:= github.com/databus23/helm-diff/v3
 LDFLAGS := -X $(PKG)/cmd.Version=$(VERSION)
@@ -19,11 +19,11 @@ install: build
 	cp bin/diff $(HELM_HOME)/plugins/helm-diff/bin
 	cp plugin.yaml $(HELM_HOME)/plugins/helm-diff/
 
-.PHONY: install/helm3
-install/helm3: build
-	mkdir -p $(HELM_3_PLUGINS)/helm-diff/bin
-	cp bin/diff $(HELM_3_PLUGINS)/helm-diff/bin
-	cp plugin.yaml $(HELM_3_PLUGINS)/helm-diff/
+.PHONY: install/helm
+install/helm: build
+	mkdir -p $(HELM_PLUGINS)/helm-diff/bin
+	cp bin/diff $(HELM_PLUGINS)/helm-diff/bin
+	cp plugin.yaml $(HELM_PLUGINS)/helm-diff/
 
 .PHONY: lint
 lint:

README.md

@@ -43,7 +43,7 @@ The first step is to download the repository and enter the directory. You can do
 Next, install the plugin into helm.
 
 ```bash
-make install/helm3
+make install/helm
 ```
 
 

cmd/helm.go

@@ -330,7 +330,6 @@ func (d *diffCmd) template(isUpgrade bool) ([]byte, error) {
 	} else {
 		if !d.disableValidation && d.clusterAccessAllowed() {
 			isHelmV4, err := isHelmVersionGreaterThanEqual(helmV4Version)
-			fmt.Printf("Is helm v4: %v, err: %v\n", isHelmV4, err)
 			if err == nil && isHelmV4 {
 				// Flag --validate has been deprecated, use '--dry-run=server' instead in Helm v4+
 				flags = append(flags, "--dry-run=server")