Addressed PR comments

Author: Priyanka-Patil14

docs/docs/validations.md

@@ -2794,7 +2794,7 @@ Due to excessive `svccoreCtrlr` or `svccoreNode` managed objects, Apic gui stuck
 
 The svccoreCtrlr and svccoreNode objects represent core files related to Apic and Leaf/Spines process respectively.
 
-Due to [CSCws84232][67], the APIC GUI may become unresponsive after login, with dashboards stuck in a continuous "Loading…"state.
+Due to [CSCws84232][67], the APIC GUI may become unresponsive after login, with dashboards stuck in a continuous “Loading…”state.
 Administrators may be unable to access or operate the APIC GUI, potentially impacting day-to-day management or upgrade.
 
 This check will verify the count of the `svccoreCtrlr` Managed Object and raise and alarm with the bug if object count found more than 240. Remove the content or objects of `svccoreCtrlr` or `svccoreNode`. Contact Cisco TAC or upgrade to a release containing the fix for CSCws84232 before proceeding with an upgrade.
@@ -2803,13 +2803,10 @@ This check will verify the count of the `svccoreCtrlr` Managed Object and raise
 
 Due to [CSCwt69100][70], a stale `dbgacEpgSummaryTask` object stuck in `processing` state with empty content can cause the policymgr process to crash on all APICs during an upgrade or process restart.
 
-Affected versions: version <= 6.1(5e) or version <= 6.2(1g).
-
-The check queries for `dbgacEpgSummaryTask` objects with `operSt="processing"` and `startTs` older than 24 hours. Such objects are considered stale and unexpected. If found, delete them before proceeding with the upgrade to prevent policymgr from crashing on restart.
+Delete any stale `dbgacEpgSummaryTask` objects before proceeding to prevent policymgr from crashing on restart.
 
 
 [0]: https://github.com/datacenter/ACI-Pre-Upgrade-Validation-Script
-[70]: https://bst.cloudapps.cisco.com/bugsearch/bug/CSCwt69100
 [1]: https://www.cisco.com/c/dam/en/us/td/docs/Website/datacenter/apicmatrix/index.html
 [2]: https://www.cisco.com/c/en/us/support/switches/nexus-9000-series-switches/products-release-notes-list.html
 [3]: https://www.cisco.com/c/en/us/td/docs/dcn/aci/apic/5x/release-notes/cisco-aci-nx-os-release-notes-1501.html#_Toc140580685

tests/checks/stale_epg_summary_task_check/dbgacEpgSummaryTask_boundary_combo.json

@@ -0,0 +1,20 @@
+[
+    {
+        "dbgacEpgSummaryTask": {
+            "attributes": {
+                "dn": "action/policymgrsubj-[uni/tn-TN_PROD/epgToEpg-EPG_PROD_FE_TO_EPG_PROD_BE/dstepg-[uni/tn-TN_PROD/ap-AP_PROD/epg-EPG_PROD_BE]]/dbgacEpgSummaryTask-ReportODACDef",
+                "operSt": "processing",
+                "startTs": "2026-01-14T11:00:00.000+00:00"
+            }
+        }
+    },
+    {
+        "dbgacEpgSummaryTask": {
+            "attributes": {
+                "dn": "action/policymgrsubj-[uni/tn-TN_TEST/epgToEpg-EPG_TEST_A_TO_EPG_TEST_B/dstepg-[uni/tn-TN_TEST/ap-AP_TEST/epg-EPG_TEST_B]]/dbgacEpgSummaryTask-ReportODACDef",
+                "operSt": "processing",
+                "startTs": "2026-01-14T12:01:00.000+00:00"
+            }
+        }
+    }
+]

tests/checks/stale_epg_summary_task_check/dbgacEpgSummaryTask_exactly_24h.json

@@ -0,0 +1,11 @@
+[
+    {
+        "dbgacEpgSummaryTask": {
+            "attributes": {
+                "dn": "action/policymgrsubj-[uni/tn-TN_PROD/epgToEpg-EPG_PROD_FE_TO_EPG_PROD_BE/dstepg-[uni/tn-TN_PROD/ap-AP_PROD/epg-EPG_PROD_BE]]/dbgacEpgSummaryTask-ReportODACDef",
+                "operSt": "processing",
+                "startTs": "2026-01-14T12:00:00.000+00:00"
+            }
+        }
+    }
+]

tests/checks/stale_epg_summary_task_check/test_stale_epg_summary_task_check.py

@@ -43,10 +43,17 @@ def mock_datetime(monkeypatch):
 @pytest.mark.parametrize(
     "tversion, icurl_outputs, expected_result, expected_data",
     [
-        # Case 1: Target version 6.2(2a) is beyond both affected ranges (6.1(5e) and 6.2(1g)).
+        # Case 1: tversion is missing. Expected: MANUAL.
+        (
+            None,
+            {},
+            script.MANUAL,
+            [],
+        ),
+        # Case 2: Target version 6.2(1h) is beyond both affected ranges (6.1(5e) and 6.2(1g)).
         # The target binary has the fix so version gate fails. Expected: NA without any API calls.
         (
-            "6.2(2a)",
+            "6.2(1h)",
             {},
             script.NA,
             [],
@@ -103,11 +110,36 @@ def mock_datetime(monkeypatch):
                 ]
             ],
         ),
+        # Case 6: Task started exactly 24 hours ago (startTs == threshold).
+        # Boundary condition: task_dt < threshold is False when equal. Expected: PASS.
+        (
+            "6.1(5e)",
+            {
+                task_api: read_data(dir, "dbgacEpgSummaryTask_exactly_24h.json"),
+            },
+            script.PASS,
+            [],
+        ),
+        # Case 7: Two tasks — one at 25 hours (stale) and one at 23h59m (not stale).
+        # Only the 25h task crosses the threshold. Expected: FAIL_O with one row.
+        (
+            "6.1(5e)",
+            {
+                task_api: read_data(dir, "dbgacEpgSummaryTask_boundary_combo.json"),
+            },
+            script.FAIL_O,
+            [
+                [
+                    "action/policymgrsubj-[uni/tn-TN_PROD/epgToEpg-EPG_PROD_FE_TO_EPG_PROD_BE/dstepg-[uni/tn-TN_PROD/ap-AP_PROD/epg-EPG_PROD_BE]]/dbgacEpgSummaryTask-ReportODACDef",
+                    "2026-01-14T11:00:00.000+00:00",
+                ]
+            ],
+        ),
     ],
 )
 def test_logic(run_check, mock_icurl, mock_datetime, tversion, icurl_outputs, expected_result, expected_data):
     result = run_check(
-        tversion=script.AciVersion(tversion),
+        tversion=script.AciVersion(tversion) if tversion else None,
     )
     assert result.result == expected_result
     assert result.data == expected_data