Removed stale pconsRa check. (#287)

* Removed stale pconsRa check.

* doc to call out deprecated checks

* remove app infra references + standardize deprecated checks docs

* verbiage cleanup

* whitespace cleanup

---------

Co-authored-by: Gabriel <gmonroy@cisco.com>

Author: welkinhe

aci-preupgrade-validation-script.py

@@ -5192,56 +5192,6 @@ def ave_eol_check(tversion, **kwargs):
     return Result(result=result, headers=headers, data=data, recommended_action=recommended_action, doc_url=doc_url)
 
 
-@check_wrapper(check_title='Stale pconsRA Objects')
-def stale_pcons_ra_mo_check(cversion, tversion, **kwargs):
-    result = PASS
-    headers = ["Stale pconsRA DN", "Non-Existing DN"]
-    data = []
-    recommended_action = 'Contact Cisco TAC to delete stale pconsRA before upgrading'
-    doc_url = 'https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#stale-pconsra-object'
-
-    if not tversion:
-        return Result(result=MANUAL, msg=TVER_MISSING)
-
-    if cversion.older_than("6.0(3d)") and tversion.newer_than("6.0(3c)") and tversion.older_than("6.1(4a)"):
-        pcons_rssubtreedep_api = 'pconsRsSubtreeDep.json?query-target-filter=wcard(pconsRsSubtreeDep.tDn,"/instdn-")'
-        pcons_rssubtreedep_mo = icurl('class', pcons_rssubtreedep_api)
-        pcons_inst_dn_reg = r'registry/class-\d+/instdn-\[(?P<policy_dn>.+?)\]/ra'
-        pcons_ra_dn_reg = r'(?P<pcons_ra_dn>.+?)/p...-\['
-
-        pcons_ra_set = set()
-        policy_dn_set = set()
-
-        for mo in pcons_rssubtreedep_mo:
-            pcons_rssubtreedep_tdn = mo['pconsRsSubtreeDep']['attributes']['tDn']
-            instdn_found = re.search(pcons_inst_dn_reg, pcons_rssubtreedep_tdn)
-            radn_found = re.search(pcons_ra_dn_reg, pcons_rssubtreedep_tdn)
-            if instdn_found and radn_found:
-                pcons_ra_dn = radn_found.group('pcons_ra_dn')
-                policy_dn = instdn_found.group('policy_dn')
-                if pcons_ra_dn not in pcons_ra_set:
-                    pcons_ra_set.add(pcons_ra_dn)
-                if policy_dn not in policy_dn_set:
-                    policy_dn_set.add(policy_dn)
-
-        for policy_dn in policy_dn_set:
-            policy_dn_api = policy_dn + '.json'
-            policy_dn_mo = icurl('mo', policy_dn_api)
-            if not policy_dn_mo:
-                for pcons_ra_dn in pcons_ra_set:
-                    if policy_dn in pcons_ra_dn:
-                        pcons_ra_api = pcons_ra_dn + '.json'
-                        pcons_ra_dn_mo = icurl('mo', pcons_ra_api)
-                        if pcons_ra_dn_mo:
-                            data.append([pcons_ra_dn, policy_dn])
-    else:
-        return Result(result=NA, msg=VER_NOT_AFFECTED)
-
-    if data:
-        result = FAIL_O
-    return Result(result=result, headers=headers, data=data, recommended_action=recommended_action, doc_url=doc_url)
-
-
 @check_wrapper(check_title='ISIS DTEPs Byte Size')
 def isis_database_byte_check(tversion, **kwargs):
     result = PASS
@@ -5510,7 +5460,6 @@ def get_checks(api_only, debug_function):
         n9408_model_check,
         pbr_high_scale_check,
         standby_sup_sync_check,
-        stale_pcons_ra_mo_check,
         isis_database_byte_check,
 
     ]

docs/docs/validations.md

@@ -16,6 +16,7 @@ theme:
   favicon: assets/logo.svg
 markdown_extensions:
   - admonition
+  - attr_list
 
   # code blocks
   - pymdownx.highlight: