Skip to content

Commit 61651e4

Browse files
Addressed PR comments
1 parent 20ceb84 commit 61651e4

15 files changed

Lines changed: 9 additions & 7 deletions

aci-preupgrade-validation-script.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6410,15 +6410,15 @@ def svccore_excessive_data_check(**kwargs):
64106410
return Result(result=ERROR, msg="Error occurred while fetching svccore object counts: {}".format(str(e)), doc_url=doc_url)
64116411

64126412

6413-
@check_wrapper(check_title='N9300 Switch Memory')
6414-
def n9300_switch_memory_check(fabric_nodes, **kwargs):
6413+
@check_wrapper(check_title='N9K-C93180YC-FX3 Switch Memory')
6414+
def n9k_c93180yc_fx3_switch_memory_check(fabric_nodes, **kwargs):
64156415
result = PASS
64166416
headers = ["NodeId", "Name", "Model", "Memory Detected (GB)"]
64176417
data = []
64186418
unformatted_headers = ['DN', 'Total']
64196419
unformatted_data = []
64206420
recommended_action = 'Increase the switch memory to at least 32GB on affected N9K-C93180YC-FX3 switches.'
6421-
doc_url = 'https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#n9300-switch-memory'
6421+
doc_url = 'https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#n9k-c93180yc-fx3-switch-memory'
64226422
min_memory_kb = 32 * 1000 * 1000
64236423
msg = ''
64246424

@@ -6595,7 +6595,7 @@ class CheckManager:
65956595
validate_32_64_bit_image_check,
65966596
fabric_link_redundancy_check,
65976597
apic_downgrade_compat_warning_check,
6598-
n9300_switch_memory_check,
6598+
n9k_c93180yc_fx3_switch_memory_check,
65996599
svccore_excessive_data_check,
66006600

66016601
# Faults

docs/docs/validations.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ Items | This Script
3939
[APIC downgrade compatibility when crossing 6.2 release][g19]| :white_check_mark: | :no_entry_sign:
4040
[Supported Hardware Compatibility][g20] | :white_check_mark: | :no_entry_sign:
4141
[Svccore Excessive Data Check][g21] | :white_check_mark: | :no_entry_sign:
42+
[N9K-C93180YC-FX3 Switch Memory][g22] | :white_check_mark: | :no_entry_sign:
4243

4344
[g1]: #compatibility-target-aci-version
4445
[g2]: #compatibility-cimc-version
@@ -61,6 +62,7 @@ Items | This Script
6162
[g19]: #apic-downgrade-compatibility-when-crossing-62-release
6263
[g20]: #supported-hardware-compatibility
6364
[g21]: #svccore-excessive-data-check
65+
[g22]: #n9k-c93180yc-fx3-switch-memory
6466

6567
### Fault Checks
6668
Items | Faults | This Script | APIC built-in
@@ -2743,9 +2745,9 @@ To avoid this risk, consider disabling Auto Firmware Update before upgrading to
27432745
!!! note
27442746
This issue occurs because older switch firmware versions are not compatible with switch images 6.0(3) or newer. The APIC version is not a factor.
27452747

2746-
### N9300 Switch Memory
2748+
### N9K-C93180YC-FX3 Switch Memory
27472749

2748-
This check applies to N9K-C93180YC-FX3 switches only. It reviews `procMemUsage` and flags nodes with less than 32GB memory installed. This check is not version dependent and runs for all upgrade versions.
2750+
This check applies to N9K-C93180YC-FX3 switches only. It checks whether the switch is using 16GB or 32GB of memory and flags switches running on 16GB memory. This check is not version dependent and runs for all upgrade versions.
27492751

27502752
Impact: Running an N9K-C93180YC-FX3 switch with less than 32GB memory can lead to memory pressure and increase the risk of service instability.
27512753

tests/checks/n9300_switch_memory_32g_check/fabricNode_non_n9300.json renamed to tests/checks/n9k_c93180yc_fx3_switch_memory_check/fabricNode_non_n9300.json

File renamed without changes.

tests/checks/n9300_switch_memory_32g_check/fabricNode_one.json renamed to tests/checks/n9k_c93180yc_fx3_switch_memory_check/fabricNode_one.json

File renamed without changes.

tests/checks/n9300_switch_memory_32g_check/fabricNode_two.json renamed to tests/checks/n9k_c93180yc_fx3_switch_memory_check/fabricNode_two.json

File renamed without changes.

tests/checks/n9300_switch_memory_32g_check/fabricNode_two_fx3.json renamed to tests/checks/n9k_c93180yc_fx3_switch_memory_check/fabricNode_two_fx3.json

File renamed without changes.

tests/checks/n9300_switch_memory_32g_check/procMemUsage_all_gt32gb.json renamed to tests/checks/n9k_c93180yc_fx3_switch_memory_check/procMemUsage_all_gt32gb.json

File renamed without changes.

tests/checks/n9300_switch_memory_32g_check/procMemUsage_fail_and_missing.json renamed to tests/checks/n9k_c93180yc_fx3_switch_memory_check/procMemUsage_fail_and_missing.json

File renamed without changes.

tests/checks/n9300_switch_memory_32g_check/procMemUsage_gt32gb.json renamed to tests/checks/n9k_c93180yc_fx3_switch_memory_check/procMemUsage_gt32gb.json

File renamed without changes.

tests/checks/n9300_switch_memory_32g_check/procMemUsage_invalid_total.json renamed to tests/checks/n9k_c93180yc_fx3_switch_memory_check/procMemUsage_invalid_total.json

File renamed without changes.

0 commit comments

Comments
 (0)