all data values to str + pytest case

Author: monrog2

aci-preupgrade-validation-script.py

@@ -958,7 +958,7 @@ def craftData(column, rows):
                 raise ValueError("Row length ({}), data: {} does not match column length ({}).".format(r_len, rows[row_entry], c_len))
             entry = {}
             for col_pos in range(c_len):
-                entry[column[col_pos]] = rows[row_entry][col_pos]
+                entry[column[col_pos]] = str(rows[row_entry][col_pos])
             data.append(entry)
         return data
 

tests/test_AciResult.py

@@ -137,7 +137,7 @@
             "test reason",
             "https://test_doc_url.html",
             ["col1", "col2", "col3"],
-            [["row1", "row2", "row3"], ["row4", "row5", "row6"]],
+            [["row1", "row2", 3], ["row4", "row5", 3]],
             [],
             [],
             True,
@@ -156,7 +156,7 @@
             [],
             [],
             ["col1", "col2", "col3"],
-            [["row1", "row2", "row3"], ["row4", "row5", "row6"]],
+            [["row1", "row2", 3], ["row4", "row5", 3]],
             True,
             "critical",
             "failed"
@@ -188,7 +188,12 @@ def test_AciResult(
     assert data["showValidation"] == expected_show
     assert data["severity"] == expected_criticality
     assert data["ruleStatus"] == expected_passed
-
+    for entry in data["failureDetails"]["data"]:
+        for vals in entry.values():
+            assert isinstance(vals, str)
+    for entry in data["failureDetails"]["unformatted_data"]:
+        for vals in entry.values():
+            assert isinstance(vals, str)
 
 @pytest.mark.parametrize(
     "headers, data",
@@ -209,8 +214,22 @@ def test_invalid_headers_or_data(headers, data):
 @pytest.mark.parametrize(
     "headers, data",
     [
-        (["col1", "col2"], [["row1"], ["row2"]]),  # Rows are shorter
-        (["col1"], [["row1", "row2"], ["row3", "row4"]]),  # columns are shorter
+        # Rows are shorter
+        (
+            ["col1", "col2"],
+            [
+                ["row1"],
+                ["row2"]
+            ]
+        ),
+        # columns are shorter
+        (
+            ["col1"],
+            [
+                ["row1", "row2"],
+                ["row3", "row4"]
+            ]
+        ),
     ]
 )
 def test_mismatched_lengths(headers, data):