Fix: svccoreNode mo check is updated

Author: veenaskumar-cisco

aci-preupgrade-validation-script.py

@@ -6026,21 +6026,22 @@ def apic_downgrade_compat_warning_check(cversion, tversion, **kwargs):
     return Result(result=result, headers=headers, data=data, recommended_action=recommended_action, doc_url=doc_url)
 
 
-@check_wrapper(check_title="svccoreCtrlr excessive entries check")
-def svccoreCtrlr_excessive_entries_check(tversion, **kwargs):
+@check_wrapper(check_title="svccoreCtrlr or svccoreNode excessive entries check")
+def svccoreCtrlr_or_svccoreNode_excessive_entries_check(tversion, **kwargs):
     result = PASS
-    headers = ['svccoreCtrlr Object Count']
+    headers = ['svccoreCtrlr Object Count','svccoreNode Object Count']
     data = []
     recommended_action = "Contact Cisco TAC for Support before upgrade"
-    doc_url = "https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#svccoreCtrlr-excessive-entries-check"
+    doc_url = "https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#svccoreCtrlr-or-svccoreNode-excessive-entries-check"
     if not tversion:
         return Result(result=MANUAL, msg=TVER_MISSING)
     if tversion.older_than("6.2(1h)") or tversion.same_as("6.2(1h)"):
         svccore_classes = icurl('class', 'svccoreCtrlr.json')
-        if(len(svccore_classes) > 240):
-            data.append([len(svccore_classes)])
+        svccoreNode_classes = icurl('class', 'svccoreNode.json')
+        if(len(svccore_classes) > 2 or len(svccoreNode_classes) > 2):
+            data.append([len(svccore_classes), len(svccoreNode_classes)])
         if data:
-            result = FAIL_O
+            result = MANUAL
         return Result(result=result,headers=headers,data=data,recommended_action=recommended_action,doc_url=doc_url)
     else:
         return Result(result=NA, msg=VER_NOT_AFFECTED)
@@ -6133,7 +6134,7 @@ class CheckManager:
         validate_32_64_bit_image_check,
         fabric_link_redundancy_check,
         apic_downgrade_compat_warning_check,
-        svccoreCtrlr_excessive_entries_check,
+        svccoreCtrlr_or_svccoreNode_excessive_entries_check,
 
         # Faults
         apic_disk_space_faults_check,

docs/docs/validations.md

@@ -193,7 +193,7 @@ Items                                           | Defect       | This Script
 [Stale pconsRA Object][d26]                     | CSCwp22212   | :warning:{title="Deprecated"} | :no_entry_sign:
 [ISIS DTEPs Byte Size][d27]                     | CSCwp15375   | :white_check_mark: | :no_entry_sign:
 [Policydist configpushShardCont Crash][d28]     | CSCwp95515   | :white_check_mark: | 
-[svccoreCtrlr excessive entries check][d30]     | CSCws8423    | :white_check_mark: | 
+[svccoreCtrlr or svccoreNode excessive entries check][d30]     | CSCws8423    | :white_check_mark: | 
 
 [d1]: #ep-announce-compatibility
 [d2]: #eventmgr-db-size-defect-susceptibility
@@ -223,7 +223,7 @@ Items                                           | Defect       | This Script
 [d26]: #stale-pconsra-object
 [d27]: #isis-dteps-byte-size
 [d28]: #policydist-configpushshardcont-crash
-[d30]: #svccoreCtrlr-excessive-entries-check
+[d30]: #svccoreCtrlr-or-svccoreNode-excessive-entries-check
 
 
 ## General Check Details
@@ -2650,9 +2650,9 @@ Due to [CSCwp95515][59], upgrading to an affected version while having any `conf
 If any instances of `configpushShardCont` are flagged by this script, Cisco TAC must be contacted to identify and resolve the underlying issue before performing the upgrade.
 
 
-### svccoreCtrlr excessive entries check
+### svccoreCtrlr or svccoreNode excessive entries check
 
-Due to excessive `svccoreCtrlr` or `svccoreNode` managed objects, queries are stuck in (pending) status.
+Due to excessive `svccoreCtrlr` or `svccoreNode` managed objects, Apic gui stuck in loading multiple queries.
 
 Due to [CSCws84232][62], the APIC GUI may become unresponsive after login, with dashboards stuck in a continuous “Loading…”state.
 Administrators may be unable to access or operate the APIC GUI, potentially impacting day-to-day management or upgrade.