run_cmd pytest

Author: monrog2

aci-preupgrade-validation-script.py

@@ -1278,8 +1278,8 @@ def run_cmd(cmd, splitlines=True):
             return response.splitlines()
         return response
     except subprocess.CalledProcessError as e:
-        log.error("Command '%s' failed with error: %s", cmd, e.output.strip())
-        return None
+        log.error("Command '%s' failed with error: %s", cmd, str(e))
+        raise e
 
 
 def get_credentials():
@@ -5458,7 +5458,6 @@ def get_checks(api_only, debug_function):
         apic_version_md5_check,
         apic_database_size_check,
 
-
         # Faults
         standby_apic_disk_space_check,
         apic_ssd_check,

tests/test_run_cmd.py

@@ -0,0 +1,30 @@
+import pytest
+import importlib
+from subprocess import CalledProcessError
+script = importlib.import_module("aci-preupgrade-validation-script")
+
+
+@pytest.mark.parametrize(
+    "cmd, splitlines, expected_output",
+    [
+        (["echo", "$'hello\nworld'"], True, ["hello", "world"]),
+        ("echo $'hello\nworld'", True, ["hello", "world"]),
+        (["echo", "$'hello\nworld'"], False, "hello\nworld\n"),
+        ("echo $'hello\nworld'", False, "hello\nworld\n"),
+    ],
+)
+def test_run_cmds(cmd, splitlines, expected_output):
+    result = script.run_cmd(cmd, splitlines)
+    assert result == expected_output
+
+
+@pytest.mark.parametrize(
+    "cmd, splitlines, expected_output",
+    [
+        ("fake_command", True, ""),
+        (["fake_command"], False, ""),
+    ]
+)
+def test_non_existing_command(cmd, splitlines, expected_output):
+    with pytest.raises(CalledProcessError):
+        script.run_cmd(cmd, splitlines)