issue NewValidation for CSCws84232

Fixes #333 solved

Author: jeestr4d

aci-preupgrade-validation-script.py

@@ -6026,6 +6026,50 @@ def apic_downgrade_compat_warning_check(cversion, tversion, **kwargs):
     return Result(result=result, headers=headers, data=data, recommended_action=recommended_action, doc_url=doc_url)
 
 
+@check_wrapper(check_title="Ctrlr and Node svccore count")
+def svccore_ctrl_and_node_check(tversion, **kwargs):
+    result = FAIL_UF
+    headers = ["Node ID", "svccoreCtrlr/Node Count"]
+    data = []
+    recommended_action = 'Contact TAC to remove the exceeding svccoreCtrlr, svccoreNode MOs before upgrade.'
+    doc_url = "https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#ctrlr-and-node-svccore-count"
+
+    if not tversion:
+        return Result(result=MANUAL, msg=TVER_MISSING)
+
+    if tversion.newer_than("6.2(1a)"):
+        return Result(result=NA, msg='Targer version not affected')
+    
+    svccoreCtrlr = icurl("class","svccoreCtrlr.json")
+    svccoreNode = icurl( "class","svccoreNode.json")
+
+    svccoreCtrlr_mos = len(svccoreCtrlr) 
+    svccoreNode_mos = len(svccoreNode)
+    total_mos = svccoreCtrlr_mos + svccoreNode_mos
+
+    if total_mos > 240:
+        files_per_node = {}
+        for mo in chain(svccoreCtrlr, svccoreNode):
+            if mo.get("svccoreCtrlr"):
+                node = mo["svccoreCtrlr"]["attributes"]["ctrlrId"]
+            else:
+                node = mo["svccoreNode"]["attributes"]["nodeId"]
+            files_per_node[node] = files_per_node.get(node, 0 ) + 1
+    
+        for node, files in files_per_node.items():
+            data.append([node, files])        
+
+    if not data:
+        result = PASS
+    return Result(
+        result=result,
+        headers=headers,
+        data=data,
+        recommended_action=recommended_action,
+        doc_url=doc_url,
+    )
+
+
 # ---- Script Execution ----
 
 
@@ -6188,6 +6232,7 @@ class CheckManager:
         standby_sup_sync_check,
         isis_database_byte_check,
         configpush_shard_check,
+        svccore_ctrl_and_node_check,
 
     ]
     ssh_checks = [

docs/docs/validations.md

@@ -193,6 +193,7 @@ Items                                           | Defect       | This Script
 [Stale pconsRA Object][d26]                     | CSCwp22212   | :warning:{title="Deprecated"} | :no_entry_sign:
 [ISIS DTEPs Byte Size][d27]                     | CSCwp15375   | :white_check_mark: | :no_entry_sign:
 [Policydist configpushShardCont Crash][d28]     | CSCwp95515   | :white_check_mark: | 
+[Ctrlr and Node svccore count][d29]             | CSCws84232   | :white_check_mark: | :no_entry_sign:
 
 [d1]: #ep-announce-compatibility
 [d2]: #eventmgr-db-size-defect-susceptibility
@@ -222,6 +223,7 @@ Items                                           | Defect       | This Script
 [d26]: #stale-pconsra-object
 [d27]: #isis-dteps-byte-size
 [d28]: #policydist-configpushshardcont-crash
+[d29]: #ctrlr-and-node-svccore-count
 
 
 ## General Check Details
@@ -2648,6 +2650,15 @@ Due to [CSCwp95515][59], upgrading to an affected version while having any `conf
 If any instances of `configpushShardCont` are flagged by this script, Cisco TAC must be contacted to identify and resolve the underlying issue before performing the upgrade.
 
 
+### Ctrlr and Node svcore count
+
+ACI creates a svccoreCtrlr (for APICs) or svccoreNode (for ACI Switches) MO any time a Service crashes with a Core, thus maintaining a record per services per node.
+
+Due to [CSCws84232][62] if the number of these records is considerable (+200), upon upgrade the APIC dashboards can become stuck in "Loading..." and the GUI becomes unresponsive. 
+
+If the script alerts about the number of MOs in the database, Cisco TAC must be contacted to clean any exceeding record before the upgrade.
+
+
 [0]: https://github.com/datacenter/ACI-Pre-Upgrade-Validation-Script
 [1]: https://www.cisco.com/c/dam/en/us/td/docs/Website/datacenter/apicmatrix/index.html
 [2]: https://www.cisco.com/c/en/us/support/switches/nexus-9000-series-switches/products-release-notes-list.html
@@ -2710,3 +2721,4 @@ If any instances of `configpushShardCont` are flagged by this script, Cisco TAC
 [59]: https://bst.cloudapps.cisco.com/bugsearch/bug/CSCwp95515
 [60]: https://www.cisco.com/c/en/us/solutions/collateral/data-center-virtualization/application-centric-infrastructure/white-paper-c11-743951.html#Inter
 [61]: https://www.cisco.com/c/en/us/solutions/collateral/data-center-virtualization/application-centric-infrastructure/white-paper-c11-743951.html#EnablePolicyCompression
+[62]: https://bst.cloudapps.cisco.com/bugsearch/bug/CSCws84232