Updated review comments

Author: asraf-khan

aci-preupgrade-validation-script.py

@@ -6410,7 +6410,7 @@ def svccore_excessive_data_check(**kwargs):
         return Result(result=ERROR, msg="Error occurred while fetching svccore object counts: {}".format(str(e)), doc_url=doc_url)
 
 
-@check_wrapper(check_title='False Micron SSD failure_fault')
+@check_wrapper(check_title='False Micron SSD failure fault')
 def false_micron_ssd_failure_fault_check(cversion, tversion, **kwargs):
     result = PASS
     headers = ['Pod', 'Node', 'Model']
@@ -6419,7 +6419,7 @@ def false_micron_ssd_failure_fault_check(cversion, tversion, **kwargs):
         '\n\tRun the SSD Lifetime Validation script manually on all identified nodes before upgrading.\n'
         '\tScript location: https://github.com/datacenter/aci-tac-scripts/tree/main/SSD%20Lifetime%20Validation\n'
     )
-    doc_url = 'https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#false-micron-ssd-failure_fault'
+    doc_url = 'https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#false-micron-ssd-failure-fault'
 
     if not tversion:
         return Result(result=MANUAL, msg=TVER_MISSING)
@@ -6439,7 +6439,7 @@ def false_micron_ssd_failure_fault_check(cversion, tversion, **kwargs):
         data.append([pod_id, node_id, attr.get('model','')])
 
     if data:
-        result = FAIL_O
+        result = MANUAL
 
     return Result(result=result, headers=headers, data=data, recommended_action=recommended_action, doc_url=doc_url)
 

docs/docs/validations.md

@@ -203,7 +203,7 @@ Items                                           | Defect       | This Script
 [N9K-C9408 with more than 5 N9K-X9400-16W LEMs][d31] | CSCws82819   | :white_check_mark: | :no_entry_sign:
 [Multi-Pod Modular Spine Bootscript File][d32]  | CSCwr66848   | :white_check_mark: | :no_entry_sign:
 [Inband Management Policy Misconfiguration][d33]| CSCwd40071   | :white_check_mark: | :no_entry_sign:
-[False Micron SSD failure_fault][d34]           | CSCwt38698   | :white_check_mark: | :no_entry_sign:
+[False Micron SSD failure fault][d34]           | CSCwt38698   | :white_check_mark: | :no_entry_sign:
 
 [d1]: #ep-announce-compatibility
 [d2]: #eventmgr-db-size-defect-susceptibility
@@ -238,7 +238,7 @@ Items                                           | Defect       | This Script
 [d31]: #n9k-c9408-with-more-than-5-n9k-x9400-16w-lems
 [d32]: #multi-pod-modular-spine-bootscript-file
 [d33]: #inband-management-policy-misconfiguration
-[d34]: #false-micron-ssd-failure_fault
+[d34]: #false-micron-ssd-failure-fault
 
 ## General Check Details
 
@@ -2799,11 +2799,11 @@ Administrators may be unable to access or operate the APIC GUI, potentially impa
 
 This check will verify the count of the `svccoreCtrlr` Managed Object and raise and alarm with the bug if object count found more than 240. Remove the content or objects of `svccoreCtrlr` or `svccoreNode`. Contact Cisco TAC or upgrade to a release containing the fix for CSCws84232 before proceeding with an upgrade.
 
-### False Micron SSD failure_fault
+### False Micron SSD failure fault
 
 Due to [CSCwt38698][70], certain Micron SSDs present in the fabric may experience premature end-of-life failures after upgrading to `6.1(5e)` or `6.2(1g)`.
 
-To avoid this issue, change the target version to another version. Or run the **SSD Lifetime Validation** script on all nodes with identified Micron SSDs prior to upgrading to determine the remaining SSD lifetime. If the SSD lifetime is critically low, you have to follow the SSD replacement procedure outlined in the field notice to ensure that the node remains available after the upgrade. In case you already upgraded your node and are experiencing unavailability due to this issue, contact Cisco TAC for the SSD replacement procedure to restore the node.
+To avoid this issue, change the target version to non-impacted version. TO confirm if this is genuine or false alarm run the SSD Lifetime Validation script on all nodes with identified actual failure case. If the SSD lifetime is critically low after manually running the script, you have to follow the SSD replacement procedure outlined in the field notice to ensure that the node remains available after the upgrade. In case you already upgraded your node and experiencing unavailability due to this issue, contact Cisco TAC for the SSD replacement procedure to restore the node.
 
 - Script location: [SSD Lifetime Validation](https://github.com/datacenter/aci-tac-scripts/tree/main/SSD%20Lifetime%20Validation)
 

tests/checks/false_micron_ssd_failure_fault_check/test_false_micron_ssd_failure_fault_check.py

@@ -56,32 +56,32 @@
             script.PASS,
             [],
         ),
-        # Test 7: FAIL_O - tversion affected 6.1(5e), cversion not affected, single Micron drive
+        # Test 7: MANUAL - tversion affected 6.1(5e), cversion not affected, single Micron drive
         (
             {eqptflash_micron: micron_drives_single},
             "6.1(5e)", "6.0(2h)",
-            script.FAIL_O,
+            script.MANUAL,
             [["1", "101", "MTFDDAK240MBB"]],
         ),
-        # Test 8: FAIL_O - tversion affected 6.2(1g), cversion not affected, single Micron drive
+        # Test 8: MANUAL - tversion affected 6.2(1g), cversion not affected, single Micron drive
         (
             {eqptflash_micron: micron_drives_single},
             "6.2(1g)", "6.0(2h)",
-            script.FAIL_O,
+            script.MANUAL,
             [["1", "101", "MTFDDAK240MBB"]],
         ),
-        # Test 9: FAIL_O - tversion not affected, cversion affected 6.1(5e), single Micron drive
+        # Test 9: MANUAL - tversion not affected, cversion affected 6.1(5e), single Micron drive
         (
             {eqptflash_micron: micron_drives_single},
             "6.2(2a)", "6.1(5e)",
-            script.FAIL_O,
+            script.MANUAL,
             [["1", "101", "MTFDDAK240MBB"]],
         ),
-        # Test 10: FAIL_O - multiple Micron drives across pods and nodes
+        # Test 10: MANUAL - multiple Micron drives across pods and nodes
         (
             {eqptflash_micron: micron_drives_multi},
             "6.1(5e)", "6.0(2h)",
-            script.FAIL_O,
+            script.MANUAL,
             [
                 ["1", "101", "MTFDDAK240MBB"],
                 ["2", "201", "MTFDDAK480MBB"],