PUV updates#254
Merged
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
takishida
requested changes
Jun 25, 2025
takishida
previously requested changes
Jun 26, 2025
Collaborator
Author
|
Added the following args for now admin@apic1:techsupport> python aci-preupgrade-validation-script.py -h
usage: aci-preupgrade-validation-script.py [-h] [-v VERSION] [-s]
options:
-h, --help show this help message and exit
-v VERSION, --version VERSION
CCO Version string, e.g. 6.0(2a)
-s, --scriptcontainer
Running in APIC script container, icurl checks onlyAssumption is that script container will call the script with both flags: apic:~> python aci-preupgrade-validation-script.py -s -v '6.0(2a)' |
* Clean up get_vpc_nodes() and its pytest * Split the main script execution code into each func and add pytest * Retire json_log and adopt json per rule for both PUV and regular use + linting
…on (#259) * feat: Support QA version and AciVersion instance as input in AciVersion * fix: Use supported version format in older_than * fix: Use ValueError in AciVersion
This comment was marked as outdated.
This comment was marked as outdated.
* -c (cversion) and -d (debug_function) for dev testing * pytest fix WIP * fixed pytest
A new decorator `@check_wrapper` is to move most of the I/O functionalities, such as printing and writing the result into a file, outside of each check function so that each check can focus on the validation logic itself by minimizing the impact from a requirement change in the output format and so on. To support this, a new class `Result` is also introduced to make it clear what a check function is expected to return. As long as `Result` class is returned, the decorator `@check_wrapper` handles the printing them to stdout and files.
monrog2
commented
Jul 22, 2025
Collaborator
Author
monrog2
left a comment
monrog2
left a comment
There was a problem hiding this comment.
pytests all pass now, integration tests are good as well. merging
jeestr4d
pushed a commit
that referenced
this pull request
Jul 22, 2025
* feat: synth class + write back each function as json result * fix: Clean up get_vpc_nodes() and its pytest * feat: Split the main script execution code into each func and add pytest * feat: Retire json_log and adopt json per rule for both PUV and regular use + linting * feat: Support QA version and AciVersion instance as input in AciVersion (#259) * feat: Support QA version and AciVersion instance as input in AciVersion * fix: Use supported version format in older_than * fix: Use ValueError in AciVersion * feat: -c (cversion) / -d (debug_function) args into puv (#265) * feat: Update synthMaintP with the latest schema with ruleId * feat: Add decorator `@check_wrapper` for all check functions A new decorator `@check_wrapper` is to move most of the I/O functionalities, such as printing and writing the result into a file, outside of each check function so that each check can focus on the validation logic itself by minimizing the impact from a requirement change in the output format and so on. To support this, a new class `Result` is also introduced to make it clear what a check function is expected to return. As long as `Result` class is returned, the decorator `@check_wrapper` handles the printing them to stdout and files. * feat: rename synth class to AciResult + breakdown --puv into --api-only and --no-cleanup * feat: Add --version and --total-checks input args * feat: Do not touch log folders with some options like --version * fix: ValueError when col and row len do not match + pytest * fix: correct checks with mismatched col row length * fix: cimc logic update for QA --------- Co-authored-by: takishida <38262981+takishida@users.noreply.github.com> Co-authored-by: tkishida <tkishida@cisco.com>
monrog2
added a commit
that referenced
this pull request
Sep 19, 2025
…headTx is non-zero while tailTx is zero #253 (#260) * fix for issue NewValidation: CSCwp95515 - Policydist crash-loop on upgrade if configpushShardCont headTx is non-zero while tailTx is zero #253 * Welkin issue 245 (#263) * Introduced CSCwp22212 check for stale pconsRA objects --------- Co-authored-by: Gabriel <gmonroy@cisco.com> * Add ISIS DTEP Check (#247) * Add ISIS DTEP Check --------- Co-authored-by: Gabriel <gmonroy@cisco.com> * bump to v2.6.0 * PUV updates (#254) * feat: synth class + write back each function as json result * fix: Clean up get_vpc_nodes() and its pytest * feat: Split the main script execution code into each func and add pytest * feat: Retire json_log and adopt json per rule for both PUV and regular use + linting * feat: Support QA version and AciVersion instance as input in AciVersion (#259) * feat: Support QA version and AciVersion instance as input in AciVersion * fix: Use supported version format in older_than * fix: Use ValueError in AciVersion * feat: -c (cversion) / -d (debug_function) args into puv (#265) * feat: Update synthMaintP with the latest schema with ruleId * feat: Add decorator `@check_wrapper` for all check functions A new decorator `@check_wrapper` is to move most of the I/O functionalities, such as printing and writing the result into a file, outside of each check function so that each check can focus on the validation logic itself by minimizing the impact from a requirement change in the output format and so on. To support this, a new class `Result` is also introduced to make it clear what a check function is expected to return. As long as `Result` class is returned, the decorator `@check_wrapper` handles the printing them to stdout and files. * feat: rename synth class to AciResult + breakdown --puv into --api-only and --no-cleanup * feat: Add --version and --total-checks input args * feat: Do not touch log folders with some options like --version * fix: ValueError when col and row len do not match + pytest * fix: correct checks with mismatched col row length * fix: cimc logic update for QA --------- Co-authored-by: takishida <38262981+takishida@users.noreply.github.com> Co-authored-by: tkishida <tkishida@cisco.com> * bump to v3.0.0 v3.0.0 to mark for PUV integration + accounting for the 7 new input arg options * fix for issue NewValidation: CSCwp95515 - Policydist crash-loop on upgrade if configpushShardCont headTx is non-zero while tailTx is zero #253 * testchange * changes based on version3 * logic + pytest cleanup * changed the query and content of pos file to match with bug coditions. * fix query + cleanup docs * title consistency * fix doc link --------- Co-authored-by: Welkin <48639332+welkin-he@users.noreply.github.com> Co-authored-by: Gabriel <gmonroy@cisco.com> Co-authored-by: Joe LeBlanc <joelebla@cisco.com> Co-authored-by: GM <monrog2@gmail.com> Co-authored-by: takishida <38262981+takishida@users.noreply.github.com> Co-authored-by: tkishida <tkishida@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.