Skip to content

adding of cli parameters for user and password#335

Merged
takishida merged 3 commits into
datacenter:v4.1.0-devfrom
Thatleft:master
Apr 4, 2026
Merged

adding of cli parameters for user and password#335
takishida merged 3 commits into
datacenter:v4.1.0-devfrom
Thatleft:master

Conversation

@Thatleft
Copy link
Copy Markdown
Contributor

@Thatleft Thatleft commented Jan 27, 2026

added cli parameters for user (-u) and password (-p) to be used in an eased way for fully automated execution of 'aci-preupgrade-validation-script.py'

…eased way for fully automated execution of 'aci-preupgrade-validation-script.py'
@Thatleft Thatleft changed the title add of cli parameter for user and password adding of cli parameters for user and password Jan 27, 2026
@takishida takishida changed the base branch from master to v4.1.0-dev April 4, 2026 06:04
@takishida takishida merged commit 07ea2db into datacenter:v4.1.0-dev Apr 4, 2026
2 checks passed
@takishida
Copy link
Copy Markdown
Collaborator

Example output:

admin@apic1:techsupport> python aci-preupgrade-validation-script.py -h
usage: aci-preupgrade-validation-script.py [-h] [-u USERNAME] [-p PASSWORD] [-t TVERSION] [-c CVERSION] [-d DEBUG_FUNCTION] [-a] [-n] [-v] [--total-checks] [--timeout [TIMEOUT]]
                                           [--max-threads MAX_THREADS]

ACI Pre-Upgrade Validation Script - v4.1.0-dev

options:
  -h, --help            show this help message and exit
  -u USERNAME, --username USERNAME
                        Sets username to be used. If not provied it will prompt for
  -p PASSWORD, --password PASSWORD
                        Sets password to be used. If not provied it will prompt for
  -t TVERSION, --tversion TVERSION
                        Upgrade Target Version. Ex. 6.2(1a)
  -c CVERSION, --cversion CVERSION
                        Override Current Version. Ex. 6.1(1a)
  -d DEBUG_FUNCTION, --debug-function DEBUG_FUNCTION
                        Name of a single function to debug. Ex. 'apic_version_md5_check'
  -a, --api-only        For built-in PUV. API Checks only. Checks using SSH are skipped.
  -n, --no-cleanup      Skip all file cleanup after script execution.
  -v, --version         Only show the script version, then end.
  --total-checks        Only show the total number of checks, then end.
  --timeout [TIMEOUT]   Show default script timeout (sec) or overwrite it when a number is provided (e.g. --timeout 1200).
  --max-threads MAX_THREADS
                        Maximum number of check threads to run concurrently. Defaults to unlimited.
admin@apic1:techsupport>
admin@apic1:techsupport>
admin@apic1:techsupport>
admin@apic1:techsupport> python aci-preupgrade-validation-script.py -u admin -p mysecret -t '6.2(1g)'
    ==== 2026-04-04T00-04-00-0700, Script Version v4.1.0-dev  ====

!!!! Check https://github.com/datacenter/ACI-Pre-Upgrade-Validation-Script for Latest Release !!!!

Gathering Node Information...

Current APIC Version...6.1(5e)
Lowest Switch Version...6.1(5e)

Target APIC version is overridden to 6.2(1g)

Collecting VPC Node IDs...103, 104

Progress: |████████████████████████████████████████████████████████████████████████████████████████████████████| 94/94 checks completed

--- skip ---

@oalmoman
Copy link
Copy Markdown

@takishida Thanks for your efforts, I see this issue should be fixed in 4.1.0, any idea on the release date?

@oalmoman
Copy link
Copy Markdown

oalmoman commented May 8, 2026

@takishida Can you please comment on the release date for this?

monrog2 added a commit that referenced this pull request May 21, 2026
* Add arg to define thread limit - to throttle concurrent API calls when required (#355)

* add `--max-threads` arg
* fix bad descriptor errs/race conditions
* update pytests

* 353 the script incorrectly detects vpc and port channel interfaces as cscwh68103 invalid fabricpathep targets (#357)

* specific testing for known failure conditions of cscwh68103 as to not catch valid scenarios

* Update aci-preupgrade-validation-script.py

mark version

* print cleanup

* fix: Add cversion check for post_upgrade_cb_check (#377)

* added validation for CFD CSCwp64296 (#307)

Added rogue ep/coop exception mac check for the CFD CSCwp64296

* Added pre-upgrade validation for N9K-C9408 with more than 6 N9K-X9400-16W LEM's for the bug CSCws82819 (#354)

* Added a new check for the bug 'CSCws82819N9K-C9408 boot loop on 16.1.2f and later with 6 or more LEMs'

* New Validation for APIC Storage Inode Usage (F4388, F4389, F4390 equipment-full) (#361)

* New Validation for APIC Storage Inode Usage (F4388, F4389, F4390 equipment-full)
* Add new exception handling of invalid query filter in `icurl` due to, for example, a non-supported fault code on older versions

* Add validation for multipod_modular_spine_bootscript_check - CSCwr66848 (#365)

* Add check for CFD - CSCwr66848

* Update pytest.yml to run on vX.Y.Z branches

* adding of cli parameters for user and password (#335)

* added cli parameter for user (-u) and password (-p) to be used in an eased way for fully automated execution of 'aci-preupgrade-validation-script.py'

* test: Add pytest

---------

Co-authored-by: Detlef Sass <detlef.sass@de.bosch.com>

* Added validation for CSCwd40071 (#332)

* Added validation for CSCwd40071

* Addressed the comments

* Added cversion for the check

* Removed empty spaces

* logic change. removed 0.0.0.0/0 and made pytest changes

* logic modified and validation.md file updated

* Added validation for CSCws84232 (#334)

* Feat:added svccoreCtrlr excessive entries check

* updated the formated json in svccore_negative.json

* Removed other PR checks

* Fix: svccoreNode mo check is updated

* Fix:update the threshold to 240

* refactor:moved to general check

* refactor:updated recommended action

* refactor:optimise the check for get the count alone

* refactor:added try catch exception for error handling

* update the threshold value for 240

* refactor:query-target was added

* refactor: removed unwanted spaces

* refactor:removed unwanted spaces in validation.md

* resolve conflict while rebasing

* resolve conflict while rebasing

* updated pytest script file

* updated validation.md

* addressed review comments

* updated validation.md

---------

Co-authored-by: takishida <38262981+takishida@users.noreply.github.com>

* set to v4.1.0

---------

Co-authored-by: tkishida <tkishida@cisco.com>
Co-authored-by: takishida <38262981+takishida@users.noreply.github.com>
Co-authored-by: psureshb <psureshb@cisco.com>
Co-authored-by: Harinadh-Saladi <hsaladi@cisco.com>
Co-authored-by: sanjanch <sanjanch@cisco.com>
Co-authored-by: asraf-khan <anazar@cisco.com>
Co-authored-by: Thatleft <detlef.sass@web.de>
Co-authored-by: Detlef Sass <detlef.sass@de.bosch.com>
Co-authored-by: veesenth_cisco <veesenth@cisco.com>
monrog2 added a commit that referenced this pull request May 21, 2026
* Add arg to define thread limit - to throttle concurrent API calls when required (#355)

* add `--max-threads` arg
* fix bad descriptor errs/race conditions
* update pytests

* 353 the script incorrectly detects vpc and port channel interfaces as cscwh68103 invalid fabricpathep targets (#357)

* specific testing for known failure conditions of cscwh68103 as to not catch valid scenarios

* Update aci-preupgrade-validation-script.py

mark version

* print cleanup

* Unsupported hardware check

* fix: Add cversion check for post_upgrade_cb_check (#377)

* added validation for CFD CSCwp64296 (#307)

Added rogue ep/coop exception mac check for the CFD CSCwp64296

* Added pre-upgrade validation for N9K-C9408 with more than 6 N9K-X9400-16W LEM's for the bug CSCws82819 (#354)

* Added a new check for the bug 'CSCws82819N9K-C9408 boot loop on 16.1.2f and later with 6 or more LEMs'

* New Validation for APIC Storage Inode Usage (F4388, F4389, F4390 equipment-full) (#361)

* New Validation for APIC Storage Inode Usage (F4388, F4389, F4390 equipment-full)
* Add new exception handling of invalid query filter in `icurl` due to, for example, a non-supported fault code on older versions

* Add validation for multipod_modular_spine_bootscript_check - CSCwr66848 (#365)

* Add check for CFD - CSCwr66848

* Update pytest.yml to run on vX.Y.Z branches

* adding of cli parameters for user and password (#335)

* added cli parameter for user (-u) and password (-p) to be used in an eased way for fully automated execution of 'aci-preupgrade-validation-script.py'

* test: Add pytest

---------

Co-authored-by: Detlef Sass <detlef.sass@de.bosch.com>

* Addressed the review comments

* Added validation for CSCwd40071 (#332)

* Added validation for CSCwd40071

* Addressed the comments

* Added cversion for the check

* Removed empty spaces

* logic change. removed 0.0.0.0/0 and made pytest changes

* logic modified and validation.md file updated

* Addressed the review comments

* Added validation for CSCws84232 (#334)

* Feat:added svccoreCtrlr excessive entries check

* updated the formated json in svccore_negative.json

* Removed other PR checks

* Fix: svccoreNode mo check is updated

* Fix:update the threshold to 240

* refactor:moved to general check

* refactor:updated recommended action

* refactor:optimise the check for get the count alone

* refactor:added try catch exception for error handling

* update the threshold value for 240

* refactor:query-target was added

* refactor: removed unwanted spaces

* refactor:removed unwanted spaces in validation.md

* resolve conflict while rebasing

* resolve conflict while rebasing

* updated pytest script file

* updated validation.md

* addressed review comments

* updated validation.md

---------

Co-authored-by: takishida <38262981+takishida@users.noreply.github.com>

* Removed gen1_switch_compatibility_check

---------

Co-authored-by: GM <monrog2@gmail.com>
Co-authored-by: Gabriel <gmonroy@cisco.com>
Co-authored-by: tkishida <tkishida@cisco.com>
Co-authored-by: takishida <38262981+takishida@users.noreply.github.com>
Co-authored-by: psureshb <psureshb@cisco.com>
Co-authored-by: Harinadh-Saladi <hsaladi@cisco.com>
Co-authored-by: sanjanch <sanjanch@cisco.com>
Co-authored-by: asraf-khan <anazar@cisco.com>
Co-authored-by: Thatleft <detlef.sass@web.de>
Co-authored-by: Detlef Sass <detlef.sass@de.bosch.com>
Co-authored-by: veesenth_cisco <veesenth@cisco.com>
monrog2 added a commit that referenced this pull request May 21, 2026
…age (#368)

* Add arg to define thread limit - to throttle concurrent API calls when required (#355)

* add `--max-threads` arg
* fix bad descriptor errs/race conditions
* update pytests

* 353 the script incorrectly detects vpc and port channel interfaces as cscwh68103 invalid fabricpathep targets (#357)

* specific testing for known failure conditions of cscwh68103 as to not catch valid scenarios

* Update aci-preupgrade-validation-script.py

mark version

* print cleanup

* Added code for CSCwo96334:/tmp directory disk space for snapshot storage

* Updated fix version

* Added clarification comment for /tmp snapshot handling

* fix: Add cversion check for post_upgrade_cb_check (#377)

* added validation for CFD CSCwp64296 (#307)

Added rogue ep/coop exception mac check for the CFD CSCwp64296

* Added pre-upgrade validation for N9K-C9408 with more than 6 N9K-X9400-16W LEM's for the bug CSCws82819 (#354)

* Added a new check for the bug 'CSCws82819N9K-C9408 boot loop on 16.1.2f and later with 6 or more LEMs'

* New Validation for APIC Storage Inode Usage (F4388, F4389, F4390 equipment-full) (#361)

* New Validation for APIC Storage Inode Usage (F4388, F4389, F4390 equipment-full)
* Add new exception handling of invalid query filter in `icurl` due to, for example, a non-supported fault code on older versions

* Add validation for multipod_modular_spine_bootscript_check - CSCwr66848 (#365)

* Add check for CFD - CSCwr66848

* Update pytest.yml to run on vX.Y.Z branches

* adding of cli parameters for user and password (#335)

* added cli parameter for user (-u) and password (-p) to be used in an eased way for fully automated execution of 'aci-preupgrade-validation-script.py'

* test: Add pytest

---------

Co-authored-by: Detlef Sass <detlef.sass@de.bosch.com>

* Corrected the typo for snapshot

---------

Co-authored-by: GM <monrog2@gmail.com>
Co-authored-by: Gabriel <gmonroy@cisco.com>
Co-authored-by: tkishida <tkishida@cisco.com>
Co-authored-by: takishida <38262981+takishida@users.noreply.github.com>
Co-authored-by: psureshb <psureshb@cisco.com>
Co-authored-by: sanjanch <sanjanch@cisco.com>
Co-authored-by: asraf-khan <anazar@cisco.com>
Co-authored-by: Thatleft <detlef.sass@web.de>
Co-authored-by: Detlef Sass <detlef.sass@de.bosch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants