Add N9300 switch memory check

aci-preupgrade-validation-script.py

@@ -6410,6 +6410,100 @@ def svccore_excessive_data_check(**kwargs):
         return Result(result=ERROR, msg="Error occurred while fetching svccore object counts: {}".format(str(e)), doc_url=doc_url)
 
 
+@check_wrapper(check_title='N9K-C93180YC-FX3 Switch Memory')
+def n9k_c93180yc_fx3_switch_memory_check(fabric_nodes, **kwargs):
+    result = PASS
+    headers = ["NodeId", "Name", "Model", "Memory Detected (GB)"]
+    data = []
+    unformatted_headers = ['DN', 'Total']
+    unformatted_data = []
+    recommended_action = 'Increase the switch memory to at least 32GB on affected N9K-C93180YC-FX3 switches.'
+    doc_url = 'https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#n9k-c93180yc-fx3-switch-memory'
+    min_memory_kb = 32 * 1000 * 1000
+    msg = ''
+
+    affected_nodes = [
+        node for node in fabric_nodes
+        if node['fabricNode']['attributes']['model'] == 'N9K-C93180YC-FX3'
+    ]
+
+    if not affected_nodes:
+        result = NA
+        msg = 'No N9K-C93180YC-FX3 switches found. Skipping.'
+    else:
+        proc_mem_mos = icurl('class', 'procMemUsage.json')
+        node_total_kb = {}
+
+        for memory_mo in proc_mem_mos:
+            attrs = memory_mo.get('procMemUsage', {}).get('attributes', {})
+            total = attrs.get('Total')
+            mem_dn = attrs.get('dn', '')
+            if not total or '/memusage-sup' not in mem_dn:
+                continue
+            dn_match = re.search(node_regex, mem_dn)
+            if not dn_match:
+                continue
+            try:
+                total_kb = int(total)
+            except (TypeError, ValueError):
+                unformatted_data.append([mem_dn, total])
+                continue
+
+            node_id = dn_match.group('node')
+            if node_id not in node_total_kb:
+                node_total_kb[node_id] = total_kb
+
+        missing_nodes = []
+
+        for node in affected_nodes:
+            node_id = node['fabricNode']['attributes']['id']
+            total_kb = node_total_kb.get(node_id)
+            if total_kb is None:
+                missing_nodes.append([
+                    node_id,
+                    node['fabricNode']['attributes']['name'],
+                    node['fabricNode']['attributes']['model'],
+                ])
+                continue
+
+            if total_kb < min_memory_kb:
+                memory_in_gb = round(total_kb / 1000000, 2)
+                result = MANUAL
+                data.append([
+                    node_id,
+                    node['fabricNode']['attributes']['name'],
+                    node['fabricNode']['attributes']['model'],
+                    memory_in_gb,
+                ])
+
+        if missing_nodes and data:
+            result = MANUAL
+            msg = (
+                'Some N9K-C93180YC-FX3 nodes have insufficient memory and others are missing '
+                'procMemUsage data. Please manually verify the memory on all affected nodes.\n'
+                'Nodes with insufficient memory: {}\n'
+                'Nodes with missing data: {}'.format(
+                    ', '.join(str(row[0]) for row in data),
+                    ', '.join(str(row[0]) for row in missing_nodes),
+                )
+            )
+            headers = ['NodeId', 'Name', 'Model', 'Memory Detected (GB)']
+            data = data + [row + ['N/A'] for row in missing_nodes]
+        elif missing_nodes:
+            result = ERROR
+            msg = 'Missing procMemUsage data for one or more affected N9K-C93180YC-FX3 nodes.'
+            headers = ['NodeId', 'Name', 'Model']
+            data = missing_nodes
+            recommended_action = ''
+        elif data:
+            msg = (
+                'One or more N9K-C93180YC-FX3 switches have less than 32GB of memory. '
+                'An outage is not guaranteed but can occur. Please verify and upgrade the memory on affected nodes.'
+            )
+
+    return Result(result=result, msg=msg, headers=headers, data=data, unformatted_headers=unformatted_headers, unformatted_data=unformatted_data, recommended_action=recommended_action, doc_url=doc_url)
+
+
 # ---- Script Execution ----
 
 
@@ -6501,6 +6595,7 @@ class CheckManager:
         validate_32_64_bit_image_check,
         fabric_link_redundancy_check,
         apic_downgrade_compat_warning_check,
+        n9k_c93180yc_fx3_switch_memory_check,
         svccore_excessive_data_check,
 
         # Faults

docs/docs/validations.md

@@ -39,6 +39,7 @@ Items                                                        | This Script
 [APIC downgrade compatibility when crossing 6.2 release][g19]| :white_check_mark: | :no_entry_sign:
 [Supported Hardware Compatibility][g20]                      | :white_check_mark: | :no_entry_sign:
 [Svccore Excessive Data Check][g21]                          | :white_check_mark: | :no_entry_sign:
+[N9K-C93180YC-FX3 Switch Memory][g22]                        | :white_check_mark: | :no_entry_sign:
 
 [g1]: #compatibility-target-aci-version
 [g2]: #compatibility-cimc-version
@@ -61,6 +62,7 @@ Items                                                        | This Script
 [g19]: #apic-downgrade-compatibility-when-crossing-62-release
 [g20]: #supported-hardware-compatibility
 [g21]: #svccore-excessive-data-check
+[g22]: #n9k-c93180yc-fx3-switch-memory
 
 ### Fault Checks
 Items                                         | Faults         | This Script       | APIC built-in
@@ -203,6 +205,7 @@ Items                                           | Defect       | This Script
 [N9K-C9408 with more than 5 N9K-X9400-16W LEMs][d31] | CSCws82819   | :white_check_mark: | :no_entry_sign:
 [Multi-Pod Modular Spine Bootscript File][d32]  | CSCwr66848   | :white_check_mark: | :no_entry_sign:
 [Inband Management Policy Misconfiguration][d33]| CSCwd40071   | :white_check_mark: | :no_entry_sign:
+[N9300 Switch Memory][d34]                      | -            | :white_check_mark: | :no_entry_sign:
 
 [d1]: #ep-announce-compatibility
 [d2]: #eventmgr-db-size-defect-susceptibility
@@ -237,6 +240,7 @@ Items                                           | Defect       | This Script
 [d31]: #n9k-c9408-with-more-than-5-n9k-x9400-16w-lems
 [d32]: #multi-pod-modular-spine-bootscript-file
 [d33]: #inband-management-policy-misconfiguration
+[d34]: #n9300-switch-memory
 
 ## General Check Details
 
@@ -2722,7 +2726,6 @@ Due to [CSCwp95515][59], upgrading to an affected version while having any `conf
 
 If any instances of `configpushShardCont` are flagged by this script, Cisco TAC must be contacted to identify and resolve the underlying issue before performing the upgrade.
 
-
 ### Auto Firmware Update on Switch Discovery
 
 [Auto Firmware Update on Switch Discovery][63] automatically upgrades a new switch to the target firmware version before registering it to the ACI fabric. This feature activates in three scenarios:
@@ -2742,6 +2745,14 @@ To avoid this risk, consider disabling Auto Firmware Update before upgrading to
 !!! note
     This issue occurs because older switch firmware versions are not compatible with switch images 6.0(3) or newer. The APIC version is not a factor.
 
+### N9K-C93180YC-FX3 Switch Memory
+
+This check applies to N9K-C93180YC-FX3 switches only. It checks whether the switch is using 16GB or 32GB of memory and flags switches running on 16GB memory. This check is not version dependent and runs for all upgrade versions.
+
+Impact: Running an N9K-C93180YC-FX3 switch with less than 32GB memory can lead to memory pressure and increase the risk of service instability.
+
+If any N9K-C93180YC-FX3 switch is flagged by this check, upgrade the switch memory to at least 32GB.
+
 
 ### Rogue EP Exception List missing on switches
 

tests/checks/n9k_c93180yc_fx3_switch_memory_check/fabricNode_non_n9300.json

@@ -0,0 +1,13 @@
+[
+    {
+        "fabricNode": {
+            "attributes": {
+                "dn": "topology/pod-1/node-201",
+                "id": "201",
+                "name": "leaf201",
+                "model": "N9K-C9508",
+                "role": "leaf"
+            }
+        }
+    }
+]

tests/checks/n9k_c93180yc_fx3_switch_memory_check/fabricNode_one.json

@@ -0,0 +1,13 @@
+[
+    {
+        "fabricNode": {
+            "attributes": {
+                "dn": "topology/pod-1/node-101",
+                "id": "101",
+                "name": "leaf101",
+                "model": "N9K-C93180YC-FX3",
+                "role": "leaf"
+            }
+        }
+    }
+]

tests/checks/n9k_c93180yc_fx3_switch_memory_check/fabricNode_two.json

@@ -0,0 +1,24 @@
+[
+    {
+        "fabricNode": {
+            "attributes": {
+                "dn": "topology/pod-1/node-101",
+                "id": "101",
+                "name": "leaf101",
+                "model": "N9K-C93180YC-FX3",
+                "role": "leaf"
+            }
+        }
+    },
+    {
+        "fabricNode": {
+            "attributes": {
+                "dn": "topology/pod-1/node-102",
+                "id": "102",
+                "name": "leaf102",
+                "model": "N9K-C9364C",
+                "role": "leaf"
+            }
+        }
+    }
+]

tests/checks/n9k_c93180yc_fx3_switch_memory_check/fabricNode_two_fx3.json

@@ -0,0 +1,24 @@
+[
+    {
+        "fabricNode": {
+            "attributes": {
+                "dn": "topology/pod-1/node-101",
+                "id": "101",
+                "name": "leaf101",
+                "model": "N9K-C93180YC-FX3",
+                "role": "leaf"
+            }
+        }
+    },
+    {
+        "fabricNode": {
+            "attributes": {
+                "dn": "topology/pod-1/node-102",
+                "id": "102",
+                "name": "leaf102",
+                "model": "N9K-C93180YC-FX3",
+                "role": "leaf"
+            }
+        }
+    }
+]

tests/checks/n9k_c93180yc_fx3_switch_memory_check/procMemUsage_all_gt32gb.json

@@ -0,0 +1,20 @@
+[
+    {
+        "procMemUsage": {
+            "attributes": {
+                "dn": "topology/pod-1/node-101/sys/procmem/memusage-sup",
+                "Modname": "sup",
+                "Total": "32676092"
+            }
+        }
+    },
+    {
+        "procMemUsage": {
+            "attributes": {
+                "dn": "topology/pod-1/node-102/sys/procmem/memusage-sup",
+                "Modname": "sup",
+                "Total": "32676092"
+            }
+        }
+    }
+]

tests/checks/n9k_c93180yc_fx3_switch_memory_check/procMemUsage_fail_and_missing.json

@@ -0,0 +1,11 @@
+[
+    {
+        "procMemUsage": {
+            "attributes": {
+                "dn": "topology/pod-1/node-101/sys/procmem/memusage-sup",
+                "Modname": "sup",
+                "Total": "16000000"
+            }
+        }
+    }
+]

tests/checks/n9k_c93180yc_fx3_switch_memory_check/procMemUsage_gt32gb.json

@@ -0,0 +1,11 @@
+[
+    {
+        "procMemUsage": {
+            "attributes": {
+                "dn": "topology/pod-1/node-101/sys/procmem/memusage-sup",
+                "Modname": "sup",
+                "Total": "32676092"
+            }
+        }
+    }
+]

tests/checks/n9k_c93180yc_fx3_switch_memory_check/procMemUsage_invalid_total.json

@@ -0,0 +1,11 @@
+[
+    {
+        "procMemUsage": {
+            "attributes": {
+                "dn": "topology/pod-1/node-101/sys/procmem/memusage-sup",
+                "Modname": "sup",
+                "Total": "unknown"
+            }
+        }
+    }
+]

tests/checks/n9k_c93180yc_fx3_switch_memory_check/procMemUsage_lt32gb.json

@@ -0,0 +1,11 @@
+[
+    {
+        "procMemUsage": {
+            "attributes": {
+                "dn": "topology/pod-1/node-101/sys/procmem/memusage-sup",
+                "Modname": "sup",
+                "Total": "16000000"
+            }
+        }
+    }
+]

tests/checks/n9k_c93180yc_fx3_switch_memory_check/procMemUsage_missing_affected_node.json

@@ -0,0 +1,11 @@
+[
+    {
+        "procMemUsage": {
+            "attributes": {
+                "dn": "topology/pod-1/node-201/sys/procmem/memusage-sup",
+                "Modname": "sup",
+                "Total": "32676092"
+            }
+        }
+    }
+]

tests/checks/n9k_c93180yc_fx3_switch_memory_check/procMemUsage_mixed.json

@@ -0,0 +1,20 @@
+[
+    {
+        "procMemUsage": {
+            "attributes": {
+                "dn": "topology/pod-1/node-101/sys/procmem/memusage-sup",
+                "Modname": "sup",
+                "Total": "32676092"
+            }
+        }
+    },
+    {
+        "procMemUsage": {
+            "attributes": {
+                "dn": "topology/pod-1/node-102/sys/procmem/memusage-sup",
+                "Modname": "sup",
+                "Total": "22535444"
+            }
+        }
+    }
+]

tests/checks/n9k_c93180yc_fx3_switch_memory_check/procMemUsage_node201_gt32gb.json

@@ -0,0 +1,11 @@
+[
+    {
+        "procMemUsage": {
+            "attributes": {
+                "dn": "topology/pod-1/node-201/sys/procmem/memusage-sup",
+                "Modname": "sup",
+                "Total": "32676092"
+            }
+        }
+    }
+]