-
Notifications
You must be signed in to change notification settings - Fork 50
Added new script validation for CSCwt38698 #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asraf-khan
wants to merge
19
commits into
datacenter:v4.2.0-dev
Choose a base branch
from
asraf-khan:issue5-CSCwt38698
base: v4.2.0-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
04fef19
Add arg to define thread limit - to throttle concurrent API calls whe…
monrog2 233359a
353 the script incorrectly detects vpc and port channel interfaces as…
monrog2 6d7d4d4
Update aci-preupgrade-validation-script.py
monrog2 e4defbf
print cleanup
monrog2 6a2fe7f
Merge branch 'master' of github.com:datacenter/ACI-Pre-Upgrade-Valida…
takishida d849e8e
fix: Add cversion check for post_upgrade_cb_check (#377)
takishida 67dab4b
added validation for CFD CSCwp64296 (#307)
psureshb 6ccd6d9
Added pre-upgrade validation for N9K-C9408 with more than 6 N9K-X9400…
Harinadh-Saladi ea1e0f8
New Validation for APIC Storage Inode Usage (F4388, F4389, F4390 equi…
sanjanch dc09913
Add validation for multipod_modular_spine_bootscript_check - CSCwr668…
asraf-khan d118464
Update pytest.yml to run on vX.Y.Z branches
takishida 07ea2db
adding of cli parameters for user and password (#335)
Thatleft 217dbcb
Added validation for CSCwd40071 (#332)
sanjanch 871e281
Added check for CFD - CSCwt38698
asraf-khan 26aecbe
Removed serial Number from header
asraf-khan f903294
Updated check name and added post upgrade check
asraf-khan 2789582
Updated as branch v4.2.0-dev branch
asraf-khan f12515e
Updated review comments
asraf-khan 7f286e0
Updated review comments
asraf-khan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,6 +50,7 @@ coverage.xml | |
| .hypothesis/ | ||
| .pytest_cache/ | ||
| cover/ | ||
| preupgrade_validator*.tgz | ||
|
|
||
| # Translations | ||
| *.mo | ||
|
|
||
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80 changes: 80 additions & 0 deletions
80
tests/checks/apic_storage_inode_full_check/Fault_combination.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| [ | ||
| { | ||
| "faultInst": { | ||
| "attributes": { | ||
| "ack": "no", | ||
| "alert": "no", | ||
| "cause": "equipment-full", | ||
| "changeSet": "available (Old: 37868344, New: 37859228), inodesFree (Old: 810163, New: 479339), inodesUsed (Old: 1811277, New: 2142101), inodesUtilized (Old: 70, New: 82), used (Old: 976092, New: 985208)", | ||
| "code": "F4388", | ||
| "created": "2026-03-06T11:58:43.579+00:00", | ||
| "delegated": "no", | ||
| "descr": "Storage unit /data/admin/bin/avread on Node 1 mounted at /data/admin/bin/avread is 82% full for Inodes", | ||
| "dn": "topology/pod-1/node-1/sys/ch/p-[/data/admin/bin/avread]-f-[overlayfs]/fault-F4388", | ||
| "domain": "infra", | ||
| "highestSeverity": "warning", | ||
| "lastTransition": "2026-03-06T11:58:43.579+00:00", | ||
| "lc": "raised", | ||
| "occur": "1", | ||
| "origSeverity": "warning", | ||
| "prevSeverity": "warning", | ||
| "rule": "eqpt-storage-inode-warning", | ||
| "severity": "warning", | ||
| "subject": "equipment-full", | ||
| "type": "operational" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "faultInst": { | ||
| "attributes": { | ||
| "ack": "no", | ||
| "alert": "no", | ||
| "cause": "equipment-full", | ||
| "changeSet": "available (Old: 37868344, New: 37859228), inodesFree (Old: 810163, New: 479339), inodesUsed (Old: 1811277, New: 2142101), inodesUtilized (Old: 70, New: 82), used (Old: 976092, New: 985208)", | ||
| "code": "F4388", | ||
| "created": "2026-03-06T11:58:43.587+00:00", | ||
| "delegated": "no", | ||
| "descr": "Storage unit /etc/hosts on Node 1 mounted at /etc/hosts is 82% full for Inodes", | ||
| "dn": "topology/pod-1/node-1/sys/ch/p-[/etc/hosts]-f-[overlayfs]/fault-F4388", | ||
| "domain": "infra", | ||
| "highestSeverity": "warning", | ||
| "lastTransition": "2026-03-06T11:58:43.587+00:00", | ||
| "lc": "soaking", | ||
| "occur": "1", | ||
| "origSeverity": "warning", | ||
| "prevSeverity": "warning", | ||
| "rule": "eqpt-storage-inode-warning", | ||
| "severity": "warning", | ||
| "subject": "equipment-full", | ||
| "type": "operational" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "faultInst": { | ||
| "attributes": { | ||
| "ack": "no", | ||
| "alert": "no", | ||
| "cause": "equipment-full", | ||
| "changeSet": "available (Old: 37868344, New: 37859228), inodesFree (Old: 810163, New: 479339), inodesUsed (Old: 1811277, New: 2142101), inodesUtilized (Old: 70, New: 82), used (Old: 976092, New: 985208)", | ||
| "code": "F4388", | ||
| "created": "2026-03-06T11:58:43.595+00:00", | ||
| "delegated": "no", | ||
| "descr": "Storage unit /scratch-writes on Node 1 mounted at /scratch-writes is 82% full for Inodes", | ||
| "dn": "topology/pod-1/node-1/sys/ch/p-[/scratch-writes]-f-[/dev/mapper/atx-scratch]/fault-F4388", | ||
| "domain": "infra", | ||
| "highestSeverity": "warning", | ||
| "lastTransition": "2026-03-06T11:58:43.595+00:00", | ||
| "lc": "raised-clearing", | ||
| "occur": "1", | ||
| "origSeverity": "warning", | ||
| "prevSeverity": "warning", | ||
| "rule": "eqpt-storage-inode-warning", | ||
| "severity": "warning", | ||
| "subject": "equipment-full", | ||
| "type": "operational" | ||
| } | ||
| } | ||
| } | ||
| ] |
54 changes: 54 additions & 0 deletions
54
tests/checks/apic_storage_inode_full_check/Fault_exists_not_raised.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| [ | ||
| { | ||
| "faultInst": { | ||
| "attributes": { | ||
| "ack": "no", | ||
| "alert": "no", | ||
| "cause": "equipment-full", | ||
| "changeSet": "available (Old: 37868344, New: 37859228), inodesFree (Old: 810163, New: 479339), inodesUsed (Old: 1811277, New: 2142101), inodesUtilized (Old: 70, New: 82), used (Old: 976092, New: 985208)", | ||
| "code": "F4388", | ||
| "created": "2026-03-06T11:58:43.579+00:00", | ||
| "delegated": "no", | ||
| "descr": "Storage unit /data/admin/bin/avread on Node 1 mounted at /data/admin/bin/avread is 82% full for Inodes", | ||
| "dn": "topology/pod-1/node-1/sys/ch/p-[/data/admin/bin/avread]-f-[overlayfs]/fault-F4388", | ||
| "domain": "infra", | ||
| "highestSeverity": "warning", | ||
| "lastTransition": "2026-03-06T11:58:43.579+00:00", | ||
| "lc": "cleared", | ||
| "occur": "1", | ||
| "origSeverity": "warning", | ||
| "prevSeverity": "warning", | ||
| "rule": "eqpt-storage-inode-warning", | ||
| "severity": "warning", | ||
| "subject": "equipment-full", | ||
| "type": "operational" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "faultInst": { | ||
| "attributes": { | ||
| "ack": "no", | ||
| "alert": "no", | ||
| "cause": "equipment-full", | ||
| "changeSet": "available (Old: 37868344, New: 37859228), inodesFree (Old: 810163, New: 479339), inodesUsed (Old: 1811277, New: 2142101), inodesUtilized (Old: 70, New: 82), used (Old: 976092, New: 985208)", | ||
| "code": "F4388", | ||
| "created": "2026-03-06T11:58:43.587+00:00", | ||
| "delegated": "no", | ||
| "descr": "Storage unit /etc/hosts on Node 1 mounted at /etc/hosts is 82% full for Inodes", | ||
| "dn": "topology/pod-1/node-1/sys/ch/p-[/etc/hosts]-f-[overlayfs]/fault-F4388", | ||
| "domain": "infra", | ||
| "highestSeverity": "warning", | ||
| "lastTransition": "2026-03-06T11:58:43.587+00:00", | ||
| "lc": "retaining", | ||
| "occur": "1", | ||
| "origSeverity": "warning", | ||
| "prevSeverity": "warning", | ||
| "rule": "eqpt-storage-inode-warning", | ||
| "severity": "warning", | ||
| "subject": "equipment-full", | ||
| "type": "operational" | ||
| } | ||
| } | ||
| } | ||
| ] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.